Skip to content

[Offload][AMDGPU][NFC] Improve message for warning non-XNACK runs #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronlieb merged 2 commits into from
Apr 30, 2026
Merged

[Offload][AMDGPU][NFC] Improve message for warning non-XNACK runs #2345

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d4c8ba
[Offload][AMDGPU][NFC] Improve message for warning non-XNACK runs
Kewen12 Apr 28, 2026
67136af
address comments
Kewen12 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions offload/plugins-nextgen/amdgpu/src/rtl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4818,10 +4818,11 @@ struct AMDGPUDeviceTy : public GenericDeviceTy, AMDGenericDeviceTy {
if (isUnifiedSharedMemory && !IsXnackEnabled) {
MESSAGE0(
"Running a program that requires XNACK on a system where XNACK is "
"disabled. This may cause problems when using an OS-allocated "
"pointer "
"inside a target region. "
"Re-run with HSA_XNACK=1 to remove this warning.");
"disabled or not supported. If your device supports XNACK, "
"re-run with HSA_XNACK=1. If your device does not support XNACK, "
"remove USM pragma and use map clauses instead. "
"Set OMPX_EAGER_ZERO_COPY_MAPS=1 for optimal zero-copy "
"performance on non-XNACK APUs.");
Copy link
Copy Markdown

@jplehr jplehr Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"performance on non-XNACK APUs.");
"performance on non-XNACK shared-memory devices.");

I don't know whether we should use the term APU here. I don't have a strong opinion either.

if (OMPX_StrictSanityChecks)
llvm_unreachable("User-requested hard stop on sanity check errors.");
}
Expand Down
Loading