-
Notifications
You must be signed in to change notification settings - Fork 9
Evolve domain validation mechansims #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ghalse
wants to merge
10
commits into
REFEDS:master
Choose a base branch
from
ghalse:allow-cloud-providers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c6f2ac6
Evolve domain validation mechanisms
ghalse 129eb88
Allow for validation of URN namespaces
ghalse 3c5d39c
Expand out URN acroymns
ghalse 76402c5
Revert URN-based mechanisms
ghalse 330df0b
Genericise cloud providers wording
ghalse 417c169
Vestigial reference to URNs
ghalse 6f73bde
Refine wording around endpoint certificates
ghalse 6fef40c
replace tabs with spaces for consistency (cosmetic)
ghalse 7a3d148
Merge in changes from first round of consultation
ghalse b49c4b3
s/submitting/publishing/
ghalse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tripped over this wording when I've reviewed eduGAIN applications. To me, "properly" implies that the registrar has some criterion and performs tests against the endpoints using a public service or private application, and also implies that the entity is operational at the time of registration. I'd remove "properly" to allow a process where a registrar only checks whether the endpoints are HTTPS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexstuart how about:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I like this. It would also allow test entities with certificates from an internal / private CA to be in the main metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree