Change in Code Structure for better management and error handling#940
Open
Aksh8t wants to merge 2 commits intoQwenLM:mainfrom
Open
Change in Code Structure for better management and error handling#940Aksh8t wants to merge 2 commits intoQwenLM:mainfrom
Aksh8t wants to merge 2 commits intoQwenLM:mainfrom
Conversation
Change in Code Structure for better management and error handling
rkroft
reviewed
Jan 31, 2025
| import torch | ||
| from transformers import AutoModelForCausalLM, AutoTokenizer, TextIteratorStreamer | ||
| from transformers.trainer_utils import set_seed | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes :
Encapsulation in QwenChatDemo Class: Most of the logic is encapsulated in the QwenChatDemo class. This allows easy testing, better organization, and clearer state management.
Clearer Separation of Concerns: The code is cleaner with input handling, chat logic, and command execution separated.
Error Handling: Improved error handling for user inputs and commands, ensuring the application handles edge cases better.
Code Readability: Functions are more modular, each handling a specific task (such as command handling or model loading).
Extensibility: By encapsulating the functionality into a class, you can more easily extend or modify features in the future (e.g., adding more commands or model configurations).