Raise dependency lower bounds for Downgrade CI - #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Downgrade job on master fails the tensor-arity test because its dependency versions still define zero-argument
tensormethods. Older dependencies also emit Julia 1.12 deprecation warnings. Raise only the required lower bounds using Julia's standard version specifications, preserving the later supported entries in the existing compat lists.Validation on Julia 1.12.7:
--depwarn=error --check-bounds=yes, covering tensor arity, QuantumOpticsBase, and alternative bit packing; no warnings.--depwarn=error.Pkg.testpassed on this dependency graph: 370,274 assertions, 9 existing broken tests, no failures or dependency warnings. It used CI's coverage, bounds checking, deprecation warnings, and locked-resolution settings, with this workspace's 32-thread configuration. Runtime: 12m47s. Both hosted Downgrade jobs passed before the syntax update; CI will rerun on the updated commit.The existing tests and workflows are unchanged. The action's workspace/absent-weak-dependency warnings and the cache action's Node
punycodewarning cannot be fixed through Julia compatibility bounds and remain outside this patch.Original failing run: https://github.com/QuantumSavory/QuantumClifford.jl/actions/runs/34001384946
The cold-start comparison check rejects changes to dependency metadata (
all variants must use identical Project.toml dependency metadata), so it cannot compare this compatibility update.