Repository navigation
Support CUDA.jl v6 in CuYao - #601
lana-phasecraft wants to merge 2 commits into
Conversation
|
@Roger-luo or @GiggleLiu, could I ask either of you for a review on this please? Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #601 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 90 90
Lines 5861 5861
=======================================
Hits 5229 5229
Misses 632 632 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I've figured out why the YaoToEinsum tests failed, Julia 1.13 has changed the way it hashes
Let me know what you think, thanks! |
|
It would be nice to have a separate PR fixing the tests then we can merge that PR back to this branch to get CI passing. |
|
I think we should just change the test, iut was a bit strange that the test relys on the assumptions of how dict is ordered. |
CUDA.jl 6 splits into CUDACore + library packages, and the
CUDAmodule now only forwards CUDACore's public names. CuYao relied on two non-public ones.Changes
CUDAcompat to"4, 5, 6"inProject.tomlandext/CuYao/test/Project.tomlGPUArraysandadaptviaCUDA.CUDACorewhen it exists, falling back toCUDAon 4.x/5.x (so behaviour there is unchanged)cu(::TensorNetwork)now passes throughlabel_to_qubit, required since YaoToEinsum 0.2.8 added the third field. This was failing on every CUDA version and is an unrelated fix.Testing
CuYao test suite (
ext/CuYao/test/runtests.jl) run on a GPU with CUDA 6.5.0 and 5.11.3. Happy to provide evidence of this if needed.