Skip to content

Resolve FSim parameter dispatch ambiguity - #595

Open
GiggleLiu wants to merge 1 commit into
masterfrom
automanage/fix-fsim-setiparams
Open

GiggleLiu wants to merge 1 commit into
masterfrom
automanage/fix-fsim-setiparams

Conversation

@GiggleLiu

Copy link
Copy Markdown
Member

FSimGate's untyped two-parameter setiparams! method overlaps YaoBlocks' generic numeric fallback, so Aqua reports a root-package ambiguity. Restrict the gate-specific intersection to its documented numeric parameters, preserving direct and tuple-based parameter updates while making dispatch unambiguous.

Validation:

  • Aqua.test_ambiguities(Yao) passes without suppressions on Julia 1.12.4 with Aqua 0.8.16.
  • The focused EasyBuild shortcut test file passes: 10 gate assertions and 1 visualization regression assertion.
  • git diff --check passes.

@codecov

codecov Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.29%. Comparing base (8f17bfb) to head (75e31e6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
+ Coverage   89.22%   89.29%   +0.06%     
==========================================
  Files          89       89              
  Lines        5855     5855              
==========================================
+ Hits         5224     5228       +4     
+ Misses        631      627       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant