Skip to content

fix: update column resize logic to account for RTL tables #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
priceld wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: update column resize logic to account for RTL tables #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 33 additions & 11 deletions src/columnresizing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export type ColumnResizingOptions = {
/**
* @public
*/
export type Dragging = { startX: number; startWidth: number };
export type Dragging = { startX: number; startWidth: number; isRTL: boolean };

/**
* @public
Expand Down Expand Up @@ -154,10 +154,15 @@ function handleMouseMove(
let cell = -1;
if (target) {
const { left, right } = target.getBoundingClientRect();
if (event.clientX - left <= handleWidth)
cell = edgeCell(view, event, 'left', handleWidth);
else if (right - event.clientX <= handleWidth)
cell = edgeCell(view, event, 'right', handleWidth);
if (event.clientX - left <= handleWidth) {
const tableDOM = domTableAround(target);
const isRTL = isTableRTL(tableDOM);
cell = edgeCell(view, event, isRTL ? 'end' : 'start', handleWidth);
} else if (right - event.clientX <= handleWidth) {
const tableDOM = domTableAround(target);
const isRTL = isTableRTL(tableDOM);
cell = edgeCell(view, event, isRTL ? 'start' : 'end', -handleWidth);
}
Comment on lines +157 to +165
Copy link
Copy Markdown
Author

@priceld priceld Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I duplicated the isTableRTL in each branch of the if to hopefully save a little on performance.

}

if (cell != pluginState.activeHandle) {
Expand Down Expand Up @@ -205,9 +210,11 @@ function handleMouseDown(

const cell = view.state.doc.nodeAt(pluginState.activeHandle)!;
const width = currentColWidth(view, pluginState.activeHandle, cell.attrs);
const tableDOM = domTableAround(event.target as HTMLElement);
const isRTL = isTableRTL(tableDOM);
view.dispatch(
view.state.tr.setMeta(columnResizingPluginKey, {
setDragging: { startX: event.clientX, startWidth: width },
setDragging: { startX: event.clientX, startWidth: width, isRTL },
}),
);

Expand Down Expand Up @@ -284,16 +291,28 @@ function domCellAround(target: HTMLElement | null): HTMLElement | null {
return target;
}

function domTableAround(target: HTMLElement | null): HTMLTableElement | null {
while (target && target.nodeName != 'TABLE')
target =
target.classList && target.classList.contains('ProseMirror')
? null
: (target.parentNode as HTMLElement);
return target as HTMLTableElement;
}

function isTableRTL(table: HTMLTableElement | null): boolean {
return table ? getComputedStyle(table).direction === 'rtl' : false;
}

function edgeCell(
view: EditorView,
event: MouseEvent,
side: 'left' | 'right',
handleWidth: number,
side: 'start' | 'end',
offset: number,
): number {
// posAtCoords returns inconsistent positions when cursor is moving
// across a collapsed table border. Use an offset to adjust the
// target viewport coordinates away from the table border.
const offset = side == 'right' ? -handleWidth : handleWidth;
const found = view.posAtCoords({
left: event.clientX + offset,
top: event.clientY,
Expand All @@ -302,7 +321,7 @@ function edgeCell(
const { pos } = found;
const $cell = cellAround(view.state.doc.resolve(pos));
if (!$cell) return -1;
if (side == 'right') return $cell.pos;
if (side == 'end') return $cell.pos;
const map = TableMap.get($cell.node(-1)),
start = $cell.start(-1);
const index = map.map.indexOf($cell.pos - start);
Expand All @@ -315,7 +334,10 @@ function draggedWidth(
resizeMinWidth: number,
): number {
const offset = event.clientX - dragging.startX;
return Math.max(resizeMinWidth, dragging.startWidth + offset);
return Math.max(
resizeMinWidth,
dragging.startWidth + (dragging.isRTL ? -offset : offset),
);
}

function updateHandle(view: EditorView, value: number): void {
Expand Down
2 changes: 1 addition & 1 deletion style/tables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

.ProseMirror .column-resize-handle {
position: absolute;
right: -2px;
inset-inline-end: -2px;
top: 0;
bottom: 0;
width: 4px;
Expand Down