Open
Conversation
Author
Member
|
This repository is not currently being maintained. If you want to set up (and maintain) a fork, or ask the current owners if they'll let you take over, that might work. But I don't currently have time to review PRs on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 1: fix removeRow mistake: (row < map.width) -> (row < map.height)
Before delete row
After delete row
this condition is checked merged cell in next line, so it should be

row < map.heightwhen we fixed it:
commit 2: fix removeRow when skips columns when adjusting rowspan
when skip col,we get next col,but index not update,
map.map[index]andmap.positionAt(row, col, table)is not the same cellsee issue #136