Skip to content

⚖️ [Mob 274] デスソージキのリワーク#1952

Merged
haiiro2gou merged 12 commits into
masterfrom
fix/lapis_mob274
May 16, 2026
Merged

⚖️ [Mob 274] デスソージキのリワーク#1952
haiiro2gou merged 12 commits into
masterfrom
fix/lapis_mob274

Conversation

@Lapis-LJA
Copy link
Copy Markdown
Contributor

Fix #1933

@haiiro2gou haiiro2gou requested review from ChenCMD and Copilot and removed request for ChenCMD May 16, 2026 20:52
@Lapis-LJA Lapis-LJA changed the title ⚖️ [Mob 274] デスソージキに鈍足が適用されるように ⚖️ [Mob 274] デスソージキのリワーク May 16, 2026
@haiiro2gou haiiro2gou enabled auto-merge (squash) May 16, 2026 20:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reworks mob #274 (デスソージキ / death_saw_jiki) to fix the issue #1933 where its tracking behavior became disproportionately strong in multiplayer. The rework switches the mob to inherit from the 2004.movement_speed_tp_mixin (so movement-speed debuffs apply and forward motion is handled by slide_move), replaces the score-based cooldown with a storage-based AttackCT field, and rewrites the targeting logic so it consistently targets the nearest non-spectator player rather than relying on multiple conditional tp chains that previously compounded in multiplayer.

Changes:

  • Replaces the 7M.CoolTime scoreboard cooldown with a storage-based AttackCT._/Max field and a decrement-via-int 0.9999999999-floor trick.
  • Inherits the 2004.movement_speed_tp_mixin, delegates forward motion to slide_move, and adds a new move/.mcfunction plus its alias/274/move.mcfunction.
  • Refactors targeting (tick/.mcfunction) to use @p[gamemode=!spectator] with proper distance bands, and migrates the damage routine from tick/3.damage.mcfunction to a new tick/damage.mcfunction that hits players via dx=0 box selection.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Asset/data/asset/tags/functions/mob/load.json Removes obsolete reference to deleted 0.load function.
Asset/data/asset/functions/mob/alias/274/move.mcfunction New alias dispatching the move method to the mob's own move implementation.
Asset/data/asset/functions/mob/0274.death_saw_jiki/tick/damage.mcfunction New damage routine using Field.Damage and dx=0 to hit overlapping players, then resets AttackCT.
Asset/data/asset/functions/mob/0274.death_saw_jiki/tick/3.damage.mcfunction Deletes the old damage implementation tied to the scoreboard cooldown.
Asset/data/asset/functions/mob/0274.death_saw_jiki/tick/.mcfunction Rewrites targeting/movement: nearest non-spectator player only, delegates forward motion, replaces scoreboard cooldown with AttackCT storage decrement.
Asset/data/asset/functions/mob/0274.death_saw_jiki/register.mcfunction Adds extension of mixin 2004 and declares Field.Damage and Field.AttackCT.
Asset/data/asset/functions/mob/0274.death_saw_jiki/move/.mcfunction Implements forward motion via lib:slide_move/ using this.Speed.
Asset/data/asset/functions/mob/0274.death_saw_jiki/init/.mcfunction Cancels the IsBaby 1.5x speed multiplier and aims the mob at the nearest non-spectator player on spawn.
Asset/data/asset/functions/mob/0274.death_saw_jiki/0.load.mcfunction Removes the now-unused scoreboard objective initialization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@haiiro2gou haiiro2gou merged commit 9409933 into master May 16, 2026
6 checks passed
@haiiro2gou haiiro2gou deleted the fix/lapis_mob274 branch May 16, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Mob 274] デスソージキの追尾処理がマルチで異常に強くなることがある

3 participants