Skip to content

Rename test files that contain jsx syntax to have a jsx file suffix#4288

Open
jcoyne wants to merge 1 commit into
mainfrom
tsxtests
Open

Rename test files that contain jsx syntax to have a jsx file suffix#4288
jcoyne wants to merge 1 commit into
mainfrom
tsxtests

Conversation

@jcoyne
Copy link
Copy Markdown
Collaborator

@jcoyne jcoyne commented May 1, 2026

This supports a Vite 8 upgrade.

@jcoyne jcoyne force-pushed the tsxtests branch 2 times, most recently from ca78964 to d150c6c Compare May 1, 2026 14:37
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.9%. Comparing base (eddb128) to head (2f28688).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4288     +/-   ##
=======================================
- Coverage   93.0%   92.9%   -0.1%     
=======================================
  Files        335     335             
  Lines       5538    5538             
  Branches    1955    1955             
=======================================
- Hits        5149    5143      -6     
- Misses       346     348      +2     
- Partials      43      47      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marlo-longley
Copy link
Copy Markdown
Member

@jcoyne not sure if you are aware but I made a number of commits to your other vite 8 PR, including this change

#4260

@jcoyne
Copy link
Copy Markdown
Collaborator Author

jcoyne commented May 1, 2026

@marlo-longley yes, but I think it makes sense to make this change in it's own PR as it doesn't depend on any specific vite version. It's good practice to have the file extension match the file type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants