Parse padded CIDFont /W arrays without shifting glyph widths#425
Open
splitbrain wants to merge 1 commit into
Open
Parse padded CIDFont /W arrays without shifting glyph widths#425splitbrain wants to merge 1 commit into
splitbrain wants to merge 1 commit into
Conversation
A /W array whose bracketed widths are padded with spaces (e.g. "[ 722 0 333 ]")
was split with explode(' '), turning the padding into empty strings that
floatval()'d to 0. Every consecutive width then shifted one CID along, so most
glyphs resolved to width 0 -- breaking advance-width based space insertion (the
password sample read 'H ello w o r ld' instead of 'Hello world', and several
Bundestag samples gained spurious spaces around punctuation).
Split on any run of whitespace so padded and tight brackets parse identically.
splitbrain
force-pushed
the
fix-cidfont-padded-widths
branch
from
4ee15eb to
5cd2688
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled across this issue while working on something else. This fixes a simple issue with padded
/Warrays. It fixes a few obvious whitespace bugs.