Remove mini-SWE shell timeout wrapper#1648
Open
xeophon wants to merge 2 commits into
Open
Conversation
f6438a7 to
abfa2c5
Compare
ApprovabilityVerdict: Needs human review Removes a timeout wrapper that previously limited agent execution to ~1 hour by default. This is a significant runtime behavior change that removes a safety/resource constraint, warranting human review to confirm the intent and implications. You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeoutwrapper from the packaged mini-SWE-agent command.harnessespackage version to0.1.3so the fix can be published.Root cause
The wrapper used GNU-specific
timeout --kill-after=30s. BusyBox-based task images reject that option before mini-SWE-agent starts.Impact
The sandbox API remains responsible for enforcing the command deadline through
command_timeout, so mini-SWE-agent no longer depends on a particulartimeoutbinary being installed in the task image. Publishingharnesses==0.1.3propagates the fix.Validation
uv run pytest tests/test_v1_mini_swe_agent.py -qharnesses.__version__ == "0.1.3"typre-push checks passedThis PR intentionally contains only the mini-SWE harness fix and package version bump.
Note
Low Risk
Small harness launch-script change with timeout enforcement still handled by the sandbox API; version bump only.
Overview
Removes the GNU
timeout --kill-after=30swrapper around the packaged mini-SWE-agent launch script so agent startup works on BusyBox-based task images that reject that flag.The harness now invokes
minidirectly; execution limits stay with the sandboxcommand_timeoutpath rather than a host-specifictimeoutbinary.harnessesis bumped to0.1.3for release.Reviewed by Cursor Bugbot for commit 3a36843. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Remove GNU
timeoutwrapper fromMiniSWEAgentcommand constructionRemoves the
timeout --kill-after=30s ${AGENT_TIMEOUT_SECONDS:-3600}wrapper from the bash script built in mini_swe_agent.py. The binary now runs directly without an external timeout.AGENT_TIMEOUT_SECONDSno longer has any effect; the agent process will not be forcibly killed after a timeout period.0.1.2to0.1.3.Macroscope summarized 3a36843.