Skip to content

Remove mini-SWE shell timeout wrapper#1648

Open
xeophon wants to merge 2 commits into
mainfrom
codex/fix-mini-swe-timeout
Open

Remove mini-SWE shell timeout wrapper#1648
xeophon wants to merge 2 commits into
mainfrom
codex/fix-mini-swe-timeout

Conversation

@xeophon

@xeophon xeophon commented Jun 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove the shell-level timeout wrapper from the packaged mini-SWE-agent command.
  • Bump the harnesses package version to 0.1.3 so the fix can be published.

Root cause

The wrapper used GNU-specific timeout --kill-after=30s. BusyBox-based task images reject that option before mini-SWE-agent starts.

Impact

The sandbox API remains responsible for enforcing the command deadline through command_timeout, so mini-SWE-agent no longer depends on a particular timeout binary being installed in the task image. Publishing harnesses==0.1.3 propagates the fix.

Validation

  • uv run pytest tests/test_v1_mini_swe_agent.py -q
  • direct import check confirmed harnesses.__version__ == "0.1.3"
  • Ruff, formatting, Semgrep, and ty pre-push checks passed

This PR intentionally contains only the mini-SWE harness fix and package version bump.


Note

Low Risk
Small harness launch-script change with timeout enforcement still handled by the sandbox API; version bump only.

Overview
Removes the GNU timeout --kill-after=30s wrapper around the packaged mini-SWE-agent launch script so agent startup works on BusyBox-based task images that reject that flag.

The harness now invokes mini directly; execution limits stay with the sandbox command_timeout path rather than a host-specific timeout binary. harnesses is bumped to 0.1.3 for release.

Reviewed by Cursor Bugbot for commit 3a36843. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Remove GNU timeout wrapper from MiniSWEAgent command construction

Removes the timeout --kill-after=30s ${AGENT_TIMEOUT_SECONDS:-3600} wrapper from the bash script built in mini_swe_agent.py. The binary now runs directly without an external timeout.

  • Behavioral Change: AGENT_TIMEOUT_SECONDS no longer has any effect; the agent process will not be forcibly killed after a timeout period.
  • Bumps the harness package version from 0.1.2 to 0.1.3.

Macroscope summarized 3a36843.

@xeophon xeophon force-pushed the codex/fix-mini-swe-timeout branch from f6438a7 to abfa2c5 Compare June 12, 2026 08:46
@xeophon xeophon changed the title [codex] Fix mini-SWE sandbox command handling [codex] Remove mini-SWE shell timeout wrapper Jun 12, 2026
@xeophon xeophon marked this pull request as ready for review June 12, 2026 08:55
@xeophon xeophon changed the title [codex] Remove mini-SWE shell timeout wrapper Remove mini-SWE shell timeout wrapper Jun 12, 2026
@macroscopeapp

macroscopeapp Bot commented Jun 12, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

Removes a timeout wrapper that previously limited agent execution to ~1 hour by default. This is a significant runtime behavior change that removes a safety/resource constraint, warranting human review to confirm the intent and implications.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant