Skip to content

fix: use eval config model in job id #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xeophon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use eval config model in job id #738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/prime/src/prime_cli/verifiers_bridge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,6 +992,8 @@ def run_eval_passthrough(
job_target = _env_name_from_reference(config_envs[0][0])
if job_target is None:
job_target = Path(environment).stem
if config_envs and _parse_value_option(passthrough_args, "--model", "-m") is None:
model = toml.load(environment).get("model") or model

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Validate the TOML model type before building the job id

For config-driven runs where the TOML has at least one [[eval]] entry and no CLI --model, this assigns any truthy model value directly into model; if the user has a malformed but parseable config such as model = 123 or a table, _build_job_id() immediately calls .replace() on a non-string and the CLI crashes before verifiers can report the configuration error. Please only accept a non-empty string here, otherwise fall back or raise a clear typer.Exit validation message.

Useful? React with 👍 / 👎.

job_id = _build_job_id(job_target, model)
args.extend(["--header", f"X-PI-Job-Id: {job_id}"])

Expand Down
Loading