Feat/env prefix config#2735
Draft
samsja wants to merge 3 commits into
Draft
Conversation
… source The [tool.uv.sources] override for prime-pydantic-config was being ignored because it was only a transitive dependency (via prime-rl-configs). uv only applies source overrides for packages that appear in project.dependencies. Adding it as a direct dependency makes uv resolve from the local editable path (deps/pydantic-config) instead of PyPI.
Add env_prefix ClassVar to each entrypoint config class, backed by the new env var injection in pydantic-config's BaseConfig.model_validate. Env prefixes: - RLConfig -> PRIME_RL_ - OrchestratorConfig -> PRIME_RL_ORCH_ - TrainerConfig -> PRIME_RL_TRAINER_ - InferenceConfig -> PRIME_RL_INFER_ - SFTConfig -> PRIME_RL_SFT_ - EnvServerConfig -> PRIME_RL_ENV_SERVER_ Also fix inference.py to import BaseConfig from prime_rl.utils.config for consistency with other config files. Also add prime-pydantic-config as a direct dependency in project.dependencies so uv applies the [tool.uv.sources] path override (editable install from deps/pydantic-config instead of PyPI).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.