test(gamma): add coverage for uma_resolution_status values#324
Open
skyc1e wants to merge 1 commit intoPolymarket:mainfrom
Open
test(gamma): add coverage for uma_resolution_status values#324skyc1e wants to merge 1 commit intoPolymarket:mainfrom
skyc1e wants to merge 1 commit intoPolymarket:mainfrom
Conversation
Add focused tests for the three uma_resolution_status values observed in production (proposed, disputed, resolved), plus a test confirming the field is omitted when unset. Values verified against the live Gamma API: each value returns real market data when used as a query filter. The existing all-params test already covers "resolved"; these tests cover the remaining values individually. Closes Polymarket#252
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 32 32
Lines 5167 5167
=======================================
Hits 4420 4420
Misses 747 747
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add test coverage for the three
uma_resolution_statusvalues accepted by the Gamma API:proposed— resolution has been proposed via UMA oracledisputed— proposed resolution has been disputedresolved— resolution is finalizedAlso adds a test confirming the field is omitted from the query string when unset.
Verification
Values were confirmed against the live Gamma API — each returns real market data when used as a
?uma_resolution_status=filter. TheumaResolutionStatusesfield in API responses independently confirms the same three values (e.g.["proposed", "resolved"],["proposed", "disputed"]).Changes
tests/gamma.rs: 4 new tests, no production code changesThe existing
markets_request_all_paramstest already covers"resolved". These tests cover the remaining values individually and verify omission behavior.Closes #252
Note
Low Risk
Low risk: adds only unit tests validating query string serialization for
uma_resolution_status, with no production code changes.Overview
Adds targeted query-string unit tests for
MarketsRequestto ensureuma_resolution_statusis serialized correctly for the supported values (proposed,disputed,resolved) and omitted entirely when not set.Reviewed by Cursor Bugbot for commit 5f16632. Bugbot is set up for automated code reviews on this repo. Configure here.