feat(data): add excludeDepositsWithdrawals param to ActivityRequest#307
Open
yovanoc wants to merge 2 commits intoPolymarket:mainfrom
Open
feat(data): add excludeDepositsWithdrawals param to ActivityRequest#307yovanoc wants to merge 2 commits intoPolymarket:mainfrom
yovanoc wants to merge 2 commits intoPolymarket:mainfrom
Conversation
The data-api /activity endpoint supports an excludeDepositsWithdrawals boolean parameter to filter out deposit and withdrawal activities from results. This is useful when only trading activity is needed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 32 32
Lines 5167 5167
=======================================
Hits 4420 4420
Misses 747 747
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exclude_deposits_withdrawals: Option<bool>toActivityRequestexcludeDepositsWithdrawalsto match the data-api parameter name/activityendpoint supports this parameter to filter out deposit/withdrawal activitiesNote
Low Risk
Low risk: adds a new optional query parameter to
ActivityRequestwith no changes to request execution or response parsing.Overview
Adds support for filtering
/activityresults by introducing an optionalexclude_deposits_withdrawalsflag onActivityRequest, serialized asexcludeDepositsWithdrawalsto match the Data API query parameter.Written by Cursor Bugbot for commit 25d81f8. This will update automatically on new commits. Configure here.