Skip to content

fix: NewMarket/MarketResolved WS filtering + MAKER_REBATE deserialization #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yovanoc wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −6
Open

fix: NewMarket/MarketResolved WS filtering + MAKER_REBATE deserialization #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d75481
fix: stop filtering NewMarket/MarketResolved WS events by subscribed …
yovanoc Mar 20, 2026
9160e60
Merge branch 'main' into fix/ws-market-events-and-maker-rebate
chaz-polymarket Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/clob/ws/subscription.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,12 +300,7 @@ impl SubscriptionManager {
WsMessage::LastTradePrice(ltp) => asset_ids_set.contains(&ltp.asset_id),
WsMessage::TickSizeChange(tsc) => asset_ids_set.contains(&tsc.asset_id),
WsMessage::BestBidAsk(bba) => asset_ids_set.contains(&bba.asset_id),
WsMessage::NewMarket(nm) => {
nm.asset_ids.iter().any(|id| asset_ids_set.contains(id))
},
WsMessage::MarketResolved(mr) => {
mr.asset_ids.iter().any(|id| asset_ids_set.contains(id))
},
WsMessage::NewMarket(_) | WsMessage::MarketResolved(_) => true,
_ => false,
};

Expand Down
2 changes: 2 additions & 0 deletions src/data/types/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ pub enum ActivityType {
/// Yield
Yield,
/// Maker rebate (fee rebate for providing liquidity).
#[serde(rename = "MAKER_REBATE")]
#[strum(serialize = "MAKER_REBATE")]
MakerRebate,
/// Unknown activity type from the API (captures the raw value for debugging).
#[serde(untagged)]
Expand Down
Loading