weather detector refactor - #1319
Open
Developer-Butters wants to merge 1 commit into
Open
Conversation
Collaborator
|
FYI. There is a merge conflict here. |
Developer-Butters
force-pushed
the
WeatherDetectorRefactor
branch
from
July 28, 2026 21:53
686292a to
d25b9c9
Compare
Refactored the weather detector to use waterfill instead of direct object comparison.
Developer-Butters
force-pushed
the
WeatherDetectorRefactor
branch
from
July 30, 2026 00:57
d25b9c9 to
e6d9d70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the weather icon detection logic for Pokémon LZA. The main change is a switch from a hard-coded template info table to using waterfill template matching. This should improve robustness. The test program is also updated to exercise and debug the new detection logic.
Weather Icon Detection Refactor and Improvements:
WeatherTemplateInfotable and related logic with a matcher-based approach usingWaterfillTemplateMatcherand a newWeatherFullMatcherclass, allowing for more flexible and robust template matching for each weather type.supplemental_template_checksto handle additional region-of-interest template checks for specific weather types, improving detection accuracy and making it easier to add or modify checks.WeatherIconDetectorclass to use the new matcher-based approach, removing unnecessary members and simplifying overlay logic.Test Program and Integration Updates:
Updated the test program (
TestProgramSwitch.cpp) to include the new weather detector and added a debug routine for visualizing and testing weather icon detection. [Code Cleanup:
Removed unused includes and the obsolete
WeatherTemplateInfostruct from headers, reflecting the new detection approach.