add support for rubik npu metrics#2517
Draft
samfreund wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
frontend
mcm001
reviewed
Jun 19, 2026
| const npuUsage = | ||
| data.npuUsage instanceof Map | ||
| ? new Map(data.npuUsage) | ||
| : new Map(Object.entries(data.npuUsage as Record<string, number>)); |
Contributor
There was a problem hiding this comment.
Why do we need to deal with both cases here?
|
|
||
| @Override | ||
| public double[] getNpuUsage() { | ||
| public Map<String, Double> getNpuUsage() { |
Contributor
There was a problem hiding this comment.
Does a more strongly typed data structure make more sense than a Map here?
Member
|
Some screenshots to see what it looks like would be nice btw. |
samfreund
force-pushed
the
rubik-npu-metrics
branch
from
04d62df to
2b0a20c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for NPU metrics on the Rubik Pi 3 like the ones we have on the orange pi. The metrics that we get from the rubik are different than the opi, so we now pass NPU usage as a map of strings that get displayed in the frontend. On the rubik pi there's a daemon that writes usage to a file using a key=value system, we simply read that and send to the frontend.
Blocked by PhotonVision/photon-image-modifier#146
Meta
Merge checklist: