Skip to content

ChArUco calibration board generation #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thatcomputerguy0101 wants to merge 11 commits into
base: main
Choose a base branch
from
Open

ChArUco calibration board generation #2495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e0989f4
Rename Charuco to ChArUco in SettingsTypes.ts
thatcomputerguy0101 Jun 18, 2026
f296b49
Generated ChArUco boards
thatcomputerguy0101 Jun 18, 2026
954c9e4
Remove support for generating chessboard calibration boards
thatcomputerguy0101 Jun 18, 2026
14ef3b7
Fix typo
thatcomputerguy0101 Jun 18, 2026
9c3da63
Custom paper size support
thatcomputerguy0101 Jun 18, 2026
da2e038
Use safe-units instead of mathjs
thatcomputerguy0101 Jun 18, 2026
634b736
Fix for ChArUco old pattern parity change
thatcomputerguy0101 Jun 18, 2026
1a83cf8
Switch to units-and-measurement instead
thatcomputerguy0101 Jun 18, 2026
17f17f5
Lazy load tag dictionaries
thatcomputerguy0101 Jun 18, 2026
6f66f1b
Add basic explanation of old OpenCV pattern to client tooltip
thatcomputerguy0101 Jun 19, 2026
2fcbb2c
Adaptive paper size
thatcomputerguy0101 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions photon-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,16 @@
"type-check": "vue-tsc --noEmit"
},
"dependencies": {
"@adam-rocska/units-and-measurement": "^1.2.0",
"@fontsource/prompt": "^5.2.6",
"@mdi/font": "^7.4.47",
"@msgpack/msgpack": "^3.1.2",
"aruco-marker": "github:thatcomputerguy0101/aruco-marker#update-and-dictionaries",

@GrahamSH-LLK GrahamSH-LLK May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should either

  • get published on NPM
  • refer to a commit
  • get upstreamed
    I see that you’ve sent a PR, but since the library seems relatively unmaintained the first two are probably fine

@mcm001 mcm001 May 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own curiosity, any particular reason that github: is discouraged?

@GrahamSH-LLK GrahamSH-LLK May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own curiosity, any particular reason that github: is discouraged?

Not github: in general, it's more specifically that it refers to a branch and can change under us, which is why referring to a commit hash would be fine

@thatcomputerguy0101 thatcomputerguy0101 May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pnpm lock stores the hash from the branch at the time of install, so that reinstall retrieves the same commit. Update pulls the latest contents from the branch.

@thatcomputerguy0101 thatcomputerguy0101 May 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is this package something that should be pulled in under the Photon org if the original maintainer doesn't get back to us?

@mcm001 mcm001 May 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind forking, sure

@mcm001 mcm001 May 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Ping me when/if we decide we need to do that)

"axios": "^1.11.0",
"echarts": "^6.0.0",
"jspdf": "^3.0.1",
"pinia": "^3.0.2",
"svg2pdf.js": "^2.7.0",
"three": "^0.178.0",
"vue": "^3.5.13",
"vue-router": "^4.5.1",
Expand All @@ -40,7 +43,6 @@
"@types/node": "^24.0.0",
"@types/three": "^0.178.0",
"@vitejs/plugin-vue": "^6.0.6",
"vue-tsc": "^3.2.5",
"@vue/eslint-config-prettier": "^10.2.0",
"@vue/eslint-config-typescript": "^14.5.0",
"@vue/tsconfig": "^0.7.0",
Expand All @@ -50,6 +52,7 @@
"sass": "^1.89.2",
"typescript": "^5.8.3",
"vite": "^8.0.10",
"vite-plugin-vuetify": "^2.1.1"
"vite-plugin-vuetify": "^2.1.1",
"vue-tsc": "^3.2.5"
}
}
66 changes: 50 additions & 16 deletions photon-client/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file removed photon-client/src/assets/images/ChArUco_Marker8x8.png
View file
Open in desktop
Binary file not shown.
Loading
Loading