remove reliance of HardwareManager.getInstance() first call on configmanager state#2469
Open
Bobcat66 wants to merge 2 commits into
Open
remove reliance of HardwareManager.getInstance() first call on configmanager state#2469Bobcat66 wants to merge 2 commits into
Bobcat66 wants to merge 2 commits into
Conversation
1fe4533 to
4c8500a
Compare
mcm001
reviewed
May 6, 2026
mcm001
left a comment
Contributor
There was a problem hiding this comment.
Any chance you have a Luma/LL/other camera with I/O we can test this on to make sure LEDs still work?
Contributor
Author
|
I might be able to get access to an LL2, but i'll need a few days |
Contributor
Author
|
I should have a limelight 3 next thursday, i'll post tests when I get it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2235
Meta
Merge checklist: