Skip to content

remove reliance of HardwareManager.getInstance() first call on configmanager state#2469

Open
Bobcat66 wants to merge 2 commits into
PhotonVision:mainfrom
Bobcat66:configmanager_state
Open

remove reliance of HardwareManager.getInstance() first call on configmanager state#2469
Bobcat66 wants to merge 2 commits into
PhotonVision:mainfrom
Bobcat66:configmanager_state

Conversation

@Bobcat66

@Bobcat66 Bobcat66 commented May 5, 2026

Copy link
Copy Markdown
Contributor

Closes #2235

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why, including events that led to this PR
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added
  • If this PR adds a dependency, the license has been checked for compatibility and steps taken to follow it

@Bobcat66 Bobcat66 requested a review from a team as a code owner May 5, 2026 18:26
@github-actions github-actions Bot added the backend Things relating to photon-core and photon-server label May 5, 2026
@samfreund samfreund force-pushed the configmanager_state branch from 1fe4533 to 4c8500a Compare May 5, 2026 18:30

@mcm001 mcm001 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you have a Luma/LL/other camera with I/O we can test this on to make sure LEDs still work?

@Bobcat66

Bobcat66 commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

I might be able to get access to an LL2, but i'll need a few days

@Bobcat66

Bobcat66 commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

I should have a limelight 3 next thursday, i'll post tests when I get it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove reliance on ConfigManager State on first getInstance call

2 participants