Skip to content

Require cross compiler toolchain when cross compiling#2403

Draft
Gold856 wants to merge 1 commit into
PhotonVision:mainfrom
Gold856:require-toolchain
Draft

Require cross compiler toolchain when cross compiling#2403
Gold856 wants to merge 1 commit into
PhotonVision:mainfrom
Gold856:require-toolchain

Conversation

@Gold856

@Gold856 Gold856 commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Description

Because native-utils marks toolchains as optional by default, it's possible to request a cross compilation and then... just have it not cross compile. This marks Linux cross compilers as non-optional if they are requested.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why, including events that led to this PR
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added
  • If this PR adds a dependency, the license has been checked for compatibility and steps taken to follow it

@Gold856 Gold856 requested a review from a team as a code owner March 19, 2026 06:00
@Gold856 Gold856 force-pushed the require-toolchain branch 2 times, most recently from 0f25c27 to 2954fe1 Compare March 19, 2026 06:10
@Gold856 Gold856 force-pushed the require-toolchain branch from 2954fe1 to 201a663 Compare March 19, 2026 06:11
@Gold856 Gold856 marked this pull request as draft March 19, 2026 06:26
@Gold856

Gold856 commented Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

Preferring to resolve via wpilibsuite/native-utils#21. PR will be updated when that is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant