Skip to content

Parameter parser AWG #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-buchmann wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −0
Open

Parameter parser AWG #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
396bde5
Treat AWG parameters specially
d-buchmann Jun 9, 2026
5fa167b
Add test
d-buchmann Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Services/InfoProviderSystem/DTOs/ParameterDTO.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,13 @@ public static function parseValueField(string $name, string|float $value, ?strin

//If both parts have the same unit and both values are numerical, we'll save it as range
if ($unit === $unit2 && is_numeric($number) && is_numeric($number2)) {
//If the parameter contains AWG in name or unit and min/max order is "wrong", swap it
if (preg_match('/AWG/', $name . $unit) === 1 && $number > $number2) {
$tmp = $number;
$number = $number2;
$number2 = $tmp;
}

return new self(name: $name, value_text: $value_text2, value_min: (float) $number,
value_max: (float) $number2, unit: $unit, symbol: $symbol, group: $group);
}
Expand Down
10 changes: 10 additions & 0 deletions tests/Services/InfoProviderSystem/DTOs/ParameterDTOTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,16 @@ public static function parseValueFieldDataProvider(): \Generator
'test'
];

//Test inverse AWG range
yield [
new ParameterDTO('test', value_min: 14, value_max: 22, unit: 'AWG', symbol: 'm', group: 'test'),
'test',
'22..14',
'AWG',
'm',
'test'
];

//Test ranges with tilde
yield [
new ParameterDTO('test', value_min: -1.0, value_max: 2.0, unit: 'kg', symbol: 'm', group: 'test'),
Expand Down
Loading