Skip to content

[WIP] Conversion of treasures into artifacts #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
IhateTrains wants to merge 74 commits into
base: master
Choose a base branch
from

Map more artifacts

157c52b
Select commit
Loading
Failed to load commit list.
Draft

[WIP] Conversion of treasures into artifacts #2474

Map more artifacts
157c52b
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Jan 18, 2026 in 0s

4 new issues (0 max.) of at least severity.

Annotations

Check notice on line 737 in ImperatorToCK3/CK3/Characters/CharacterCollection.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

ImperatorToCK3/CK3/Characters/CharacterCollection.cs#L737 

Remove this commented out code.

Check notice on line 762 in ImperatorToCK3/CK3/Characters/CharacterCollection.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

ImperatorToCK3/CK3/Characters/CharacterCollection.cs#L762 

Remove this commented out code.

Check notice on line 25 in ImperatorToCK3/Imperator/Provinces/Province.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

ImperatorToCK3/Imperator/Provinces/Province.cs#L25 

Make 'treasureIds' 'readonly'.

Check notice on line 46 in ImperatorToCK3/Mappers/Artifact/ArtifactMapper.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

ImperatorToCK3/Mappers/Artifact/ArtifactMapper.cs#L46 

Remove these redundant parentheses.
View more details on Codacy Production