Skip to content

Add export for jdk.internal.misc to silence joml warning in 26.3 - #395

Open
Warriorrrr wants to merge 2 commits into
mainfrom
chore/26.3-joml-silence
Open

Add export for jdk.internal.misc to silence joml warning in 26.3#395
Warriorrrr wants to merge 2 commits into
mainfrom
chore/26.3-joml-silence

Conversation

@Warriorrrr

Copy link
Copy Markdown
Member

This will allow joml to use the newer unsafe class once it's bumped in the 26.3 update and silence the warning when it falls back to the old one

@masmc05

masmc05 commented Aug 7, 2026

Copy link
Copy Markdown

Is this actually useful for paper? That option makes joml more sensitive to future java updates, while currently it only impacts a bit ExtraCodecs.MATRIX4F, which would rarely be a problem for any display entity with how much more resource intensive their other data are.

With how it's used in paper, maybe

if (System.getProperty("joml.nounsafe") == null) {
    System.setProperty("joml.nounsafe", "true");
}

In main would be better?

@Warriorrrr

Copy link
Copy Markdown
Member Author

I did it this way to match what vanilla did when they bumped it, I figure it's fine

@masmc05

masmc05 commented Aug 9, 2026

Copy link
Copy Markdown

Well client is heavily using this when sending the data to gpu, it's worth the risks especially when they have more overall control over the jdk they use. On server this only speeds up /data command when an admin/datapack specifically used the 16 float representation of the matrix and deserialisation bumps from like 3-4ns to 15ns (<0.1% of cost of running the command in both cases), the benefit is so small that I don't think it's worth even the smallest risk of weird behaviour due to the sealed jdk internals usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants