Add export for jdk.internal.misc to silence joml warning in 26.3 - #395
Add export for jdk.internal.misc to silence joml warning in 26.3#395Warriorrrr wants to merge 2 commits into
Conversation
|
Is this actually useful for paper? That option makes joml more sensitive to future java updates, while currently it only impacts a bit ExtraCodecs.MATRIX4F, which would rarely be a problem for any display entity with how much more resource intensive their other data are. With how it's used in paper, maybe if (System.getProperty("joml.nounsafe") == null) {
System.setProperty("joml.nounsafe", "true");
}In main would be better? |
|
I did it this way to match what vanilla did when they bumped it, I figure it's fine |
|
Well client is heavily using this when sending the data to gpu, it's worth the risks especially when they have more overall control over the jdk they use. On server this only speeds up |
This will allow joml to use the newer unsafe class once it's bumped in the 26.3 update and silence the warning when it falls back to the old one