Repository navigation
fix(cli): preserve literal verbosity flags after -- - #840
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The console entry point removes every
-vand--verbosetoken before the action parser sees it, including literal query text after--. For example,agent-reach web search -- --verbosebecomes a missing-query error, whileagent-reach web search -- explain --verbose optionsilently searches forexplain optionand enables logging.Only extract verbosity flags before the first
--, and forward the separator and its suffix unchanged. Existing verbose flags before that separator, including after the command, continue to work. No channel or network behavior changes.Five regression cases exercise the console entry point through the real action parser and a local fake backend: literal short/long flags, a multi-word query, explicit verbose mode combined with a literal flag, and the existing trailing-flag behavior. Four fail on unchanged main; all five pass with the fix.
Validation on Windows / Python 3.13, using the repository's dependency constraints:
ruff check agent_reach testspasses.mypy agent_reachpasses (49 source files).git diff --checkpasses.AI assistance was used for investigation, implementation and validation. No live credentials or live channel requests were used for this argument-parsing fix.