Completes basic dtypes for collective api in eager mode#45574
Merged
gongweibao merged 8 commits intoSep 6, 2022
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
HermitSun
force-pushed
the
collective-basic-dtypes
branch
2 times, most recently
from
a28b1e1 to
d0105dd
Compare
LiYuRio
reviewed
Aug 31, 2022
Contributor
There was a problem hiding this comment.
最新的gloo里是支持send，recv和alltoall的，不过我们现在的gloo是野分支，后面升级之后可以一起改。
Contributor
Author
There was a problem hiding this comment.
新版本gloo实现了alltoall，send和recv未实现，可以在后续一起修改
Contributor
Author
There was a problem hiding this comment.
gloo似乎也没有实现reduce_scatter，后续可以一起改了
HermitSun
force-pushed
the
collective-basic-dtypes
branch
from
0bbdc91 to
f13e16d
Compare
LiYuRio
previously approved these changes
Sep 1, 2022
LiYuRio
reviewed
Sep 1, 2022
HermitSun
force-pushed
the
collective-basic-dtypes
branch
from
15a0a17 to
da10aa2
Compare
…r broadcast, reduce, scatter op in eager mode
…r alltoall, sendrecv op in eager mode
…r alltoall_single, reduce_scatter op in eager mode
HermitSun
force-pushed
the
collective-basic-dtypes
branch
from
da10aa2 to
733efa6
Compare
LiYuRio
approved these changes
Sep 5, 2022
XieYunshen
approved these changes
Sep 5, 2022
Contributor
XieYunshen
left a comment
XieYunshen
left a comment
There was a problem hiding this comment.
LGTM for PROPERTIES TIMEOUT "300" LABELS "RUN_TYPE=DIST"
后续pr会降低单测执行时间
liuTINA0907
approved these changes
Sep 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
This pr completes the basic function of communication framework, support various data types.
通信框架功能进一步补全，通信操作支持传输丰富的数据类型。
TODO：