Skip to content

config: config CSS rework - #1137

Open
Rakibei wants to merge 7 commits into
OverlayPlugin:mainfrom
Rakibei:config-rework
Open

config: config CSS rework#1137
Rakibei wants to merge 7 commits into
OverlayPlugin:mainfrom
Rakibei:config-rework

Conversation

@Rakibei

@Rakibei Rakibei commented Aug 9, 2026

Copy link
Copy Markdown

Reworked a large part of the CSS for the Cactbot config.

The goal was to make it easier for the user to get an overview of the different configs sections.
Has the added benefit of adding a distinction between the different sections, as mentioned in issue #1120.

The pull request is technically ready but I would like hear some feedback so I am leaving it as a draft for now.

image image

@github-actions github-actions Bot added the config ui/config, ui/[module]/config label Aug 9, 2026
@xiashtra

xiashtra commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

My first reaction is that there is way too much padding between the elements.

@valarnin

Copy link
Copy Markdown
Collaborator

I agree with xiashtra, the amount of added padding here is going to significantly increase the scrolling required on an already massive page.

In addition, I just want to confirm - this was tested in OverlayPlugin's Cactbot Config tab, correct? I see several new CSS properties in use, and while a quick spot check didn't show any issues, OverlayPlugin's CEF/Chromium version is still at v95, which might cause compatibility issues.

(I like the overall change in look and feel here, FWIW)

@Rakibei

Rakibei commented Aug 13, 2026

Copy link
Copy Markdown
Author

I made the padding as small as I could without it looking weird, so now it is pretty much as close to the old version as possible.

And yeah I've tested it on the OverlayPlugin's inbuilt Cactbot Config tab

@valarnin so if this looks fine then I'll turn this into a normal PR

Untitled

@valarnin

Copy link
Copy Markdown
Collaborator

I'd say cut the vertical padding on the headers a bit more (maybe remove ~1/3rd or 1/4th?), and remove the CATEGORY label on the dropdown since it's redundant and is just making that section taller than it needs to.

The actual settings area looks good now to me.

image

@Rakibei

Rakibei commented Aug 25, 2026

Copy link
Copy Markdown
Author

Lowered the vertical padding by nearly half, from 18px to 10px

image

@Rakibei
Rakibei marked this pull request as ready for review August 25, 2026 14:36
@github-actions github-actions Bot added the needs-review Awaiting review label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config ui/config, ui/[module]/config needs-review Awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants