Improve repack.sh#105
Open
BrainStone wants to merge 4 commits into
Open
Conversation
No need to recreate the paths every time. Makes changing stuff easier in the long run
- `curl` can save the output file directly. This is always better than using the shell - Use the more compatible `tar` notaion - Specify compression during unpacking in `tar` (again for compatibility and best practice) - No need to iterate over the file tree several times. `find` can match multiple patterns. - The `-prune` option instructs `find` to not decend into the dirs that match, but to keep it in the file list. - No need to to pipe anything into xargs.`find` can execute commands by itself. Using the plus notation keeps the program invocations of rm to a minimum.
- `-9` means best compression - `-e` means extreme mode, which makes it try even hard to compress better - `-T0` uses all available cores to ensure a speedy compression - `-v` enables verbose mode so the progress can be followed This additonal compression reduces the file size by amlost andother MiB!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite a few changes were done.
I split them into fairly small commits so the changes are easier to follow. Each commit has a message explaining the details.
Feel free to squash the commits, if you're not a fan of many small commits, but I ask you to keep the explanations.
All changes are up for discussion and I'm aware some are certainly more opionion based than others.
My main motivation was to use the better compression and to properly use find. The other changes were added just on top because I like to tidy up bash scripts I touch.