Skip to content

Split media MDE toolbar from MDE toolbar#19164

Open
hishamco wants to merge 2 commits intomainfrom
hishamco/markdown-MDE
Open

Split media MDE toolbar from MDE toolbar#19164
hishamco wants to merge 2 commits intomainfrom
hishamco/markdown-MDE

Conversation

@hishamco
Copy link
Copy Markdown
Member

Fixes #17348

@hishamco hishamco requested a review from Piedone April 17, 2026 14:15
@hishamco
Copy link
Copy Markdown
Member Author

<script at="Foot" asp-name="MediaFieldAppInitializer" depends-on="media">
    initializeMediaApplication(false, '@Url.Action("MediaApplication", "Admin", new { area = "OrchardCore.Media" })', '@Context.Request.PathBase.ToString()');
</script>

This will be broken if the media feature is disabled

@Skrypt
Copy link
Copy Markdown
Contributor

Skrypt commented Apr 17, 2026

I think this will be fixed by the new Media Gallery. We need to inject this media icon item differently simply. Not having 2 different scripts.

@Skrypt Skrypt assigned Skrypt and unassigned Skrypt Apr 17, 2026
@Piedone
Copy link
Copy Markdown
Member

Piedone commented Apr 18, 2026

I'll defer to @Skrypt on assessing what we should do here. Also, note two things:

@hishamco
Copy link
Copy Markdown
Member Author

While @Skrypt will address this in his PR, I will not go further unless his PR takes time

@Skrypt
Copy link
Copy Markdown
Contributor

Skrypt commented Apr 19, 2026

I will fix it in the new Media gallery and come back here to report what I've found keep the PR open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the Markdown editor's implicit dependency on Media

3 participants