Use TestContainers for Azurite#19162
Use TestContainers for Azurite#19162hishamco wants to merge 2 commits intoskrypt/media-azure-gen2from
Conversation
|
@Skrypt seems several tests have been broken, please chim in |
|
On my PR I used a custom Docker image of Azurite that I'm hosting on my own Github account because Azurite doesn't support Azure Blob Storage Gen 2. You won't be able to use TestContainers for this one. Not yet at least. |
|
Let's stay with your PR for now |
| @@ -1,90 +0,0 @@ | |||
| name: Integration Tests | |||
There was a problem hiding this comment.
This was intentional to add this in the original PR. Now you are changing the CI behavior to run these integration tests on triggers that are not necessary.
| src/OrchardCore.Mvc.Web/App_Data_Tests/logs | ||
| test/OrchardCore.Tests.Functional/traces | ||
| retention-days: 3 | ||
| - name: Integration Tests |
There was a problem hiding this comment.
No, we should keep the original integration_tests.yml file.
| src/OrchardCore.Mvc.Web/App_Data_Tests/logs | ||
| test/OrchardCore.Tests.Functional/traces | ||
| retention-days: 3 | ||
| - name: Integration Tests |
| src/OrchardCore.Mvc.Web/App_Data_Tests/logs | ||
| test/OrchardCore.Tests.Functional/traces | ||
| retention-days: 3 | ||
| - name: Integration Tests |
| protected override bool IsHnsEnabled => true; | ||
|
|
||
| [AzuriteFact] | ||
| [Fact] |
There was a problem hiding this comment.
These will all fail because Azurite does not support Gen 2 storage type yet.
|
Retargeted your branch to my branch. |
2 participants
No description provided.