feat(hpm): add descriptions to HPM events - #157
Open
good-circle wants to merge 1 commit into
Open
Conversation
good-circle
requested review from
poemonsense
and
a lite review from Copilot
September 1, 2026 08:12
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class event metadata (name/value/description) for HPM performance events so descriptions can flow across module boundaries, and introduces a small utility to dump documented event sets to a CSV during elaboration.
Changes:
- Introduce
PerfEventInfo(name, value, description)and migrateHasPerfEvents/HPM monitor code to use it. - Add a tuple extension method (
withDescription) to conveniently constructPerfEventInfo. - Add
HPMDocDumputility to emit abuild/hpm.csvcontaining ordered event sets.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/scala/utility/package.scala | Adds an implicit helper to attach descriptions to (String, UInt) perf event tuples. |
| src/main/scala/utility/HPMDocDump.scala | New CSV dump utility for registered HPM event sets. |
| src/main/scala/utility/HardwarePerfMonitor.scala | Introduces PerfEventInfo and updates perf event plumbing to preserve descriptions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Carry an event description together with each HPM name and value, preserving the metadata while events pass through module boundaries. Add the small HPMDocDump utility that writes the four event sets to build/hpm.csv when elaboration requests a dump.
good-circle
force-pushed
the
kunminghu-v2-hpm
branch
from
September 4, 2026 09:21
c403de8 to
998c1e8
Compare
poemonsense
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carry an event description together with each HPM name and value, preserving the metadata while events pass through module boundaries. Add the small HPMDocDump utility that writes the four event sets to build/hpm.csv when elaboration requests a dump.