Skip to content

spec: session-1.md — register user-preference fields; one-purpose-per-field language taxonomy#122

Open
JarbasAl wants to merge 1 commit into
devfrom
spec/session-1
Open

spec: session-1.md — register user-preference fields; one-purpose-per-field language taxonomy#122
JarbasAl wants to merge 1 commit into
devfrom
spec/session-1

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Jul 4, 2026

Copy link
Copy Markdown
Member

Refines OVOS-SESSION-1 to Version 2.

  • §3.5 (new): registers location (object), system_unit, time_format, date_format (strings) — the session origin's presentation preferences, defaulting per §2.1, wire-weight rule §3.4 applies. Same section deliberately declines to register is_speaking / is_recording: instant device state snapshotted into a propagating session is stale on read; implementations MUST NOT rely on it — OVOS-AUDIO-1 lifecycle signals are authoritative.
  • §3.2: the six language fields get a one-purpose-per-field summary table, split into stable preference signals (lang, secondary_langs, output_lang) vs per-utterance observation signals (stt_lang, request_lang, detected_lang); disagreement between the two groups is signal, not error. All six kept — each records a distinct fact no other field carries. Stale "all four" count fixed.
  • §3.1: remote participants SHOULD use a distinct session_id; remote "default" SHOULD be gated behind an elevated-privilege grant in layer-2 systems.
  • §3.2.5: wake-word-derived request_lang cites its observable source ovos.listener.wakeword (AUDIO-IN-1 §6.5).
  • §3.4: notes the SESSION-2 §3.2 thin-session allowance.
  • §4.1: materialization citation corrected to MSG-1 §5.1–§5.2; phantom quotation dropped.
  • CHANGELOG entry + Version bump to 2.

Note: the §3.2.5 citation depends on the AUDIO-IN-1 §6.5 ovos.listener.wakeword signal landing in its companion PR.

🤖 Generated with Claude Code

…e taxonomy, transient-state disclaimer

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@JarbasAl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ca459ae2-b7ff-4d37-88d1-f5404ffb1bd1

📥 Commits

Reviewing files that changed from the base of the PR and between 9003dcd and 3b05aad.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • session-1.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spec/session-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl
JarbasAl marked this pull request as ready for review July 16, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant