Skip to content

spec: stop-1.md — recency-targeted stop (no escalation on silence), RECOMMENDED timeouts, shared_pipeline_id defined#117

Open
JarbasAl wants to merge 1 commit into
devfrom
spec/stop-1
Open

spec: stop-1.md — recency-targeted stop (no escalation on silence), RECOMMENDED timeouts, shared_pipeline_id defined#117
JarbasAl wants to merge 1 commit into
devfrom
spec/stop-1

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Jul 4, 2026

Copy link
Copy Markdown
Member

Refines OVOS-STOP-1 for internal purity and self-consistency (per-file split of the consistency audit).

Changes

  • Recency-targeted stop, never escalation-by-silence (§4.1 step 5, §4.2, §5.1): a generic stop with no positive pong responder falls back to the most recently activated active_handlers entry and MUST NOT escalate to global_stop. A pong can be absent for reasons unrelated to stoppability (busy handler thread, satellite round-trip beyond the ping window); escalating a missed sub-second reply to a session-wide wipe destroys converse state, response modes, and unrelated skills' activity. Recency-targeted stop degrades gracefully — at worst the dispatch is a no-op. global_stop now has exactly two triggers: explicit global-stop vocabulary and empty active_handlers.
  • Timeouts are RECOMMENDED defaults (§4.1): ping-pong window RECOMMENDED default 0.5 s, SHOULD NOT exceed 1 s (stop is the most latency-sensitive user path); the hardcoded window value is removed from the step-5 rationale so the rule does not go stale with tuning.
  • <shared_pipeline_id> defined precisely (§5.2): the pipeline_id of the stop plugin instance whose match produced the Match — the identity the global_stop dispatch addresses and PIPELINE-1 §7.1 stamps; "shared" across multiple §3.1 session.pipeline entries resolving to that instance, which MUST deduplicate to exactly one ovos.stop broadcast per global stop event per session (dedup stays MUST).
  • blacklisted_intents operationalised (§6.3): the plugin MUST NOT return a Match whose <Match.skill_id>:<Match.intent_name> appears in the list; a stop utterance resolving to global_stop is governed by the global_stop entry.
  • Cross-protocol note that the pong boolean's field name (can_handle) is protocol-local (CONVERSE uses result, COMMON-QUERY can_answer).

Principle

MUST/MUST NOT mark correctness invariants (dedup-to-one-ovos.stop, no escalation on silence, blacklist honouring); timing values are RECOMMENDED defaults. Silence is evidence of latency, not of absence of activity — destructive escalation must require positive intent (explicit vocabulary), never a timeout.

Version stays 2: VERSIONING.md defines the field as the V0-compatibility class, which these edits do not change.

🤖 Generated with Claude Code

…COMMENDED ping timeout, shared_pipeline_id defined

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@JarbasAl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: be0fb45a-dcf9-445b-8501-722a13f44fce

📥 Commits

Reviewing files that changed from the base of the PR and between 9003dcd and a25a24e.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • stop-1.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spec/stop-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl
JarbasAl marked this pull request as ready for review July 16, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant