Skip to content

spec: gui-1.md — one player time convention; confirm/select reserved#108

Open
JarbasAl wants to merge 1 commit into
devfrom
spec/gui-1
Open

spec: gui-1.md — one player time convention; confirm/select reserved#108
JarbasAl wants to merge 1 commit into
devfrom
spec/gui-1

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Jul 4, 2026

Copy link
Copy Markdown
Member

Refines OVOS-GUI-1 for internal purity.

Changes

  • One time convention across the player templates: SYSTEM_audio_player position/duration now count in milliseconds with -1 = unknown/live, matching SYSTEM_media_player. Two templates sharing one screen role must not disagree on units; a normative paragraph states the uniform convention.
  • SYSTEM_confirm / SYSTEM_select → reserved for a future version (§3.4, §7.2). Their display leg is trivial, but the reply leg (interaction event carrying the answer) has no specified topic or payload schema — an unspecified reply makes the templates unimplementable interoperably. Names stay reserved so applications cannot claim them; producers MUST NOT emit them in this version. Conformance items referencing the reply leg removed (§8.1, §8.5).
  • __idle: explicit false row; omitted-__idle deployment default now carries a RECOMMENDED value (30 s) instead of being fully unspecified — tuning value, so RECOMMENDED, not MUST.
  • Version 1 → 2: mandating ms where the pre-spec status quo used seconds is not backwards compatible (VERSIONING.md).
  • CHANGELOG entry appended under a new class-2 section.

🤖 Generated with Claude Code

Unify SYSTEM_audio_player on the SYSTEM_media_player convention:
position/duration in milliseconds, -1 = unknown/live — one convention
for one semantic pair of fields. Move SYSTEM_confirm / SYSTEM_select
to a reserved-for-future section: their reply leg has no specified
topic/payload, making them unimplementable interoperably; the names
stay reserved so applications cannot claim them. __idle gains an
explicit false row and a RECOMMENDED 30 s default for the omitted
case. Version bumps to 2 (incompatible with the pre-spec seconds
convention).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@JarbasAl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9c4b8ac1-c0a6-4de3-a014-a1957dbaba10

📥 Commits

Reviewing files that changed from the base of the PR and between 9003dcd and b94f4d6.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • gui-1.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spec/gui-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl
JarbasAl marked this pull request as ready for review July 16, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant