the device dead end, imported baselines, stale screens, widgets, prompts, double-tap

.github/workflows/pr-agent.yml

@@ -13,9 +13,37 @@ jobs:
       issues: write
       pull-requests: write
       contents: write
+    # Job-level so the step `if` below can see it: the `secrets` context is not
+    # available in an `if` expression, but `env` is.
+    env:
+      PR_AGENT_API_KEY: ${{ secrets.PR_AGENT_API_KEY }}
     steps:
+      # A PR from a fork gets no secrets, so the step below ran with an empty
+      # key, reviewed nothing, and still went green - a check that says
+      # "reviewed" when it did not is worse than no check.
+      #
+      # Skipping the step alone did not fix that: the only step is skipped, the
+      # JOB still reports success, and a green required check still reads as a
+      # pass. So SAY SO, in the one place a reader of the PR looks - the check's
+      # summary - and make the log line an annotation on the PR itself.
+      - name: Not applicable - no review key on this PR
+        if: env.PR_AGENT_API_KEY == ''
+        run: |
+          echo "::notice title=PR Agent did not run::No review key is available \
+          on this pull request (forks get no secrets), so NOTHING was reviewed. \
+          A green check here means the job finished, not that the diff passed."
+          {
+            echo "## PR Agent: not applicable"
+            echo
+            echo "No \`PR_AGENT_API_KEY\` on this run - a fork PR gets no"
+            echo "secrets. **No review was performed.** Treat this check as"
+            echo "absent, not as a pass."
+          } >> "$GITHUB_STEP_SUMMARY"
       - name: PR Agent action step
-        uses: the-pr-agent/pr-agent@main
+        if: env.PR_AGENT_API_KEY != ''
+        # Pinned, not @main: this action runs with `contents: write` and a token
+        # on every PR, and a floating ref means whatever landed upstream today.
+        uses: the-pr-agent/pr-agent@f6af7d77554ff8d26adffded077e6461329e92fa # v0.42.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           # Credentials only. The model chain lives in .pr_agent.toml so it is

.pr_agent.toml

@@ -21,9 +21,13 @@ fallback_models = [
     "openai/gpt-oss-120b-medium",
 ]
 # Required: an `openai/`-prefixed name is not in PR-Agent's MAX_TOKENS map, and
-# get_max_tokens (algo/utils.py:1008) raises rather than defaulting. Effective
-# input is still min(this, max_model_tokens=32000).
+# get_max_tokens (algo/utils.py:1008) raises rather than defaulting.
 custom_model_max_tokens = 200000
+# The effective input is min(custom_model_max_tokens, max_model_tokens), and
+# max_model_tokens defaults to 32000 - so the 200k above bought nothing and a
+# large diff was silently clipped to a third of the review it looked like it
+# got. Raise the ceiling to match.
+max_model_tokens = 200000
 
 # Inject AGENTS.md as repository context into /review, /improve, /describe, /ask.
 # NOTE: read from the DEFAULT BRANCH by default, so AGENTS.md only takes effect

PRIVACY.md

@@ -64,9 +64,10 @@ because a sideloaded app has no store to tell you a security fix exists.
 
 **Barcode lookup for food logging**
 The food log can read a barcode with the camera and fill in the nutrition
-figures for you. Doing that means asking a database, so it is **off until you
-turn it on**, and the App asks you before the first lookup ever happens — not
-after.
+figures for you. Doing that means asking a database, so it is **on by
+default**: what leaves is a number the manufacturer printed on the packet, and
+nothing about you goes with it. Turn it off and the scan stops asking anybody
+anything.
 
 - **What is sent is the barcode.** It goes to openfoodfacts.org, the free and
   open food database. Nothing about you, your meals, your health or your device
@@ -157,7 +158,7 @@ moment you tap it:
   further upload immediately, and the App tells you when the last one was.
 - **Check for updates** — turning it off stops the App making any network
   request of its own accord.
-- **Look barcodes up online** — off by default; turning it off stops any
+- **Look barcodes up online** — on by default; turning it off stops any
   further lookup immediately, and the food log keeps working by hand.
 
 You can also disable AI Coach or Health app integration at any time in Settings

README.md

@@ -79,7 +79,8 @@ drawer-bracelet problem can use it, or go dig through the code themselves.
 
 ## Checklist
 
-- **WHOOP 4.0 only.** Haven't touched a WHOOP 5, don't know if it even shares a protocol.
+- **WHOOP 4.0 is the one that's properly tested.** WHOOP 5 and MG work too, but they're
+  experimental — see the note further down.
 - Not affiliated with WHOOP, doesn't talk to their servers.
 - Not a clone of their algorithms — different math, published methods, cited in the
   analytics repo. Don't expect identical numbers to what their app shows.
@@ -143,9 +144,10 @@ shortcuts, a smart alarm that buzzes the band.
   against a lab, don't treat any of it as a diagnosis.
 - Not on the App Store or Play Store yet. iOS is a public TestFlight beta, which is a
   normal install but still a beta; Android is an APK straight off Releases.
-- WHOOP 5.0 / MG support is in progress and **experimental** — the band is detected and
-  spoken to, but it hasn't been validated against real 5.0 hardware. WHOOP 4.0 is the
-  only one that's actually tested.
+- WHOOP 5.0 / MG support is **experimental**. Both pair, sync and decode, and the work is
+  checked against real records off real bands — but 4.0 is the one I wear every day, so
+  it's the one that gets found out when it breaks. Expect rough edges on 5 and MG, and
+  open an issue when you hit one.
 
 ## Run it
 

android/app/src/main/AndroidManifest.xml

@@ -283,6 +283,28 @@
                 android:name="android.appwidget.provider"
                 android:resource="@xml/widget_openstrap_info" />
         </receiver>
+        <receiver
+            android:name=".SleepWidgetProvider"
+            android:exported="true"
+            android:label="@string/widget_sleep_picker_label">
+            <intent-filter>
+                <action android:name="android.appwidget.action.APPWIDGET_UPDATE" />
+            </intent-filter>
+            <meta-data
+                android:name="android.appwidget.provider"
+                android:resource="@xml/widget_sleep_info" />
+        </receiver>
+        <receiver
+            android:name=".OvernightWidgetProvider"
+            android:exported="true"
+            android:label="@string/widget_overnight_label">
+            <intent-filter>
+                <action android:name="android.appwidget.action.APPWIDGET_UPDATE" />
+            </intent-filter>
+            <meta-data
+                android:name="android.appwidget.provider"
+                android:resource="@xml/widget_overnight_info" />
+        </receiver>
         <receiver
             android:name=".OpenStrapBatteryWidgetProvider"
             android:exported="true"

android/app/src/main/kotlin/wtf/openstrap/openstrap_edge/OpenStrapWidgetProvider.kt

@@ -6,23 +6,28 @@ import android.content.SharedPreferences
 import android.os.Build
 import android.os.Bundle
 import android.util.SizeF
+import android.view.View
 import android.widget.RemoteViews
 import es.antonborri.home_widget.HomeWidgetPlugin
 import es.antonborri.home_widget.HomeWidgetProvider
 
 /**
- * Home-screen metrics widget — the Android sibling of OpenStrapWidget.swift
- * (Readiness headline + the Strain · Sleep · HRV rings, Ember on Paper).
+ * Home-screen metrics widget — the Android sibling of OpenStrapWidget.swift.
+ *
+ * IT IS THE SAME THREE RINGS AS HOME: Recovery · Strain · Sleep, in that order,
+ * the icon inside the dial and the number under it. It used to be four rings
+ * (Ready · Strain · Sleep · HRV) with the number inside, which was the previous
+ * design system's home screen; HRV stopped being one of Home's rings in the
+ * rebuild and lives on OvernightWidgetProvider instead.
  *
  * Renders the snapshot WidgetService.push() writes through home_widget; the app
- * broadcasts an update after every sync (this provider name is already wired in
- * widget_service.dart). Unlike iOS there is no self-refresh fetch of /today —
- * updatePeriodMillis just re-renders the cached snapshot so the theme/staleness
- * stay honest when the app hasn't run for a while.
+ * broadcasts an update after every derive and every foreground. There is no
+ * network on this side — updatePeriodMillis only re-renders the cached snapshot
+ * so the theme and the staleness rule stay honest when the app hasn't run.
  *
- * Two layouts, like the iOS families: a 2×2 ring grid (small) and a readiness
- * row over the triple rings (medium). On Android 12+ the launcher picks by live
- * size (RemoteViews size map); below that we choose from the widget's min width.
+ * Two layouts, like the iOS families: three rows (2x2) and three columns (4x2),
+ * sharing every id so there is one render path. On Android 12+ the launcher
+ * picks by live size; below that we choose from the widget's min width.
  */
 class OpenStrapWidgetProvider : HomeWidgetProvider() {
 
@@ -65,6 +70,26 @@ class OpenStrapWidgetProvider : HomeWidgetProvider() {
         manager.updateAppWidget(id, views)
     }
 
+    /** One ring's three views and the icon that goes in its dial. */
+    private class Slot(
+        val key: String,
+        val label: String,
+        val iconRes: Int,
+        val dial: Int,
+        val cap: Int,
+        val value: Int,
+        val sub: Int,
+    )
+
+    private val slots = listOf(
+        Slot("recovery", "RECOVERY", R.drawable.ic_widget_recovery,
+            R.id.dial_recovery, R.id.cap_recovery, R.id.val_recovery, R.id.sub_recovery),
+        Slot("strain", "STRAIN", R.drawable.ic_widget_strain,
+            R.id.dial_strain, R.id.cap_strain, R.id.val_strain, R.id.sub_strain),
+        Slot("sleep", "SLEEP", R.drawable.ic_widget_sleep,
+            R.id.dial_sleep, R.id.cap_sleep, R.id.val_sleep, R.id.sub_sleep),
+    )
+
     private fun build(context: Context, prefs: SharedPreferences, small: Boolean): RemoteViews {
         val w = StrapWidgets
         val pal = w.pal(prefs)
@@ -75,83 +100,56 @@ class OpenStrapWidgetProvider : HomeWidgetProvider() {
         // `updated_at` here, on every render.
         if (!w.fresh(prefs)) return buildNoData(context, pal)
 
-        // Snapshot (sentinels: -1 = no data — mirrors OpenStrapEntry).
-        val readiness = w.readInt(prefs, "readiness", -1)
-        val strain = w.readDouble(prefs, "strain", -1.0)
-        val sleepMin = w.readInt(prefs, "sleep_min", -1)
-        // -1 = none. The Dart writer uses the same sentinel; the ring below
-        // already gates on needMin > 0, so an unknown need leaves it empty
-        // instead of filling against a fabricated 8h denominator.
-        val needMin = w.readInt(prefs, "sleep_need_min", -1)
-        val hrv = w.readInt(prefs, "hrv", -1)
-        val hrvBaseline = w.readInt(prefs, "hrv_baseline", -1)
-
-        // Ring fractions — negative means "nothing measured", so ringBitmap
-        // draws the track alone rather than an arc pinned at empty (which reads
-        // as a real value of zero).
-        val readinessT = if (readiness >= 0) readiness / 100.0 else -1.0
-        val tier = w.readInt(prefs, "readiness_tier", -1)
-        val readinessArc = w.readinessArc(tier)
-        val readinessColor = w.readinessColor(tier, pal)
-        // 0-21 is the headline scale strainScore maps TRIMP onto
-        // (analytics/lib/src/onehz/clinical/load_trimp.dart:104-122).
-        val strainT = if (strain >= 0) (strain / 21.0).coerceAtMost(1.0) else -1.0
-        val sleepT = if (sleepMin >= 0 && needMin > 0) {
-            (sleepMin.toDouble() / needMin).coerceAtMost(1.0)
-        } else {
-            -1.0
-        }
-        // HRV against YOUR OWN baseline: a full ring is at or above it. There
-        // is no population scale for RMSSD, so with no baseline there is no
-        // denominator and the arc is not drawn. This used to divide by a
-        // hard-coded 100 (and by 1.5 x baseline), neither of which exists
-        // anywhere in the pipeline.
-        val hrvT = if (hrv >= 0 && hrvBaseline > 0) {
-            (hrv.toDouble() / hrvBaseline).coerceAtMost(1.0)
-        } else {
-            -1.0
-        }
-        // HRV carries its domain accent and no colour judgement: a "0.8 x
-        // baseline is amber" cut-off was invented here and appears in no
-        // analytics output.
-        val hrvColor = if (hrv >= 0) w.GREEN else w.N400
-
-        // "" = no measurement. A bare dash is the one rendering the phone's
-        // grammar forbids outright.
-        val strainText = if (strain >= 0) String.format("%.1f", strain) else ""
-        val readinessText = if (readiness >= 0) "$readiness" else ""
-        val hrvText = if (hrv >= 0) "$hrv" else ""
-
         val layout = if (small) R.layout.widget_openstrap_small else R.layout.widget_openstrap
-        val ringDp = if (small) 40 else 56
-        val strokeDp = if (small) 5f else 7f
-
+        val dialDp = if (small) 30 else 44
+        val strokeDp = if (small) 4.5f else 6f
         val views = RemoteViews(context.packageName, layout)
         views.setInt(R.id.widget_root, "setBackgroundResource", pal.bgRes)
         views.setOnClickPendingIntent(R.id.widget_root, w.openAppIntent(context))
 
-        // Readiness leads the row; its VALUE carries the readiness colour (the
-        // iOS headline treatment, compressed into a cell).
-        views.setImageViewBitmap(
-            R.id.ring_readiness,
-            w.ringBitmap(context, ringDp, strokeDp, pal.track, readinessArc, readinessT),
-        )
-        views.setTextViewText(R.id.val_readiness, readinessText)
-        views.setTextColor(R.id.val_readiness, readinessColor)
-        views.setTextColor(R.id.cap_readiness, pal.inkMuted)
+        // Recovery wears its band's colour (from the published tier — the
+        // cut-offs are never re-derived here), the other two their domain accent.
+        val tier = w.readInt(prefs, "readiness_tier", -1)
+        var gap: Pair<String, String>? = null
 
-        fun metric(ring: Int, value: Int, cap: Int, bmpColor: Int, t: Double, text: String) {
+        for (slot in slots) {
+            val r = w.ring(prefs, slot.key)
+            val accent = when (slot.key) {
+                "recovery" -> w.tierColor(tier, pal)
+                "strain" -> pal.move
+                else -> pal.sleep
+            }
+            val tint = r.color(accent, pal)
             views.setImageViewBitmap(
-                ring,
-                w.ringBitmap(context, ringDp, strokeDp, pal.track, bmpColor, t),
+                slot.dial,
+                w.dialBitmap(context, dialDp, strokeDp, pal.track, tint, r.frac, slot.iconRes),
             )
-            views.setTextViewText(value, text)
-            views.setTextColor(value, pal.ink)
-            views.setTextColor(cap, pal.inkMuted)
+            views.setTextViewText(slot.cap, slot.label)
+            views.setTextColor(slot.cap, pal.inkMuted)
+            // The absence takes the SENTENCE colour rather than the numeral
+            // one, because it is a sentence: "No sleep" in full-weight ink
+            // would read as a score.
+            views.setTextViewText(slot.value, r.value)
+            views.setTextColor(slot.value, if (r.measured) pal.ink else pal.ink2)
+            if (!small) {
+                views.setTextViewText(slot.sub, r.sub)
+                views.setTextColor(slot.sub, pal.inkMuted)
+            }
+            if (gap == null && r.why.isNotEmpty()) gap = slot.label to r.why
+        }
+
+        // The first ring that is missing and said why. One line is what a
+        // widget can afford; the rest is one tap away in the app.
+        if (!small) {
+            val g = gap
+            if (g == null) {
+                views.setViewVisibility(R.id.gap_row, View.GONE)
+            } else {
+                views.setViewVisibility(R.id.gap_row, View.VISIBLE)
+                views.setTextViewText(R.id.gap_row, "${g.first} · ${g.second}")
+                views.setTextColor(R.id.gap_row, pal.inkMuted)
+            }
         }
-        metric(R.id.ring_strain, R.id.val_strain, R.id.cap_strain, w.PURPLE, strainT, strainText)
-        metric(R.id.ring_sleep, R.id.val_sleep, R.id.cap_sleep, w.BLUE, sleepT, w.hm(sleepMin))
-        metric(R.id.ring_hrv, R.id.val_hrv, R.id.cap_hrv, hrvColor, hrvT, hrvText)
         return views
     }