Drop Python 2 compatibility branches across OMV runtime/install paths#154
Merged
Conversation
Agent-Logs-Url: https://github.com/OpenSourceBrain/osb-model-validation/sessions/8a2ac322-49af-4c5b-aa14-4e690a7bc22c Co-authored-by: pgleeson <1556687+pgleeson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/OpenSourceBrain/osb-model-validation/sessions/8a2ac322-49af-4c5b-aa14-4e690a7bc22c Co-authored-by: pgleeson <1556687+pgleeson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/OpenSourceBrain/osb-model-validation/sessions/8a2ac322-49af-4c5b-aa14-4e690a7bc22c Co-authored-by: pgleeson <1556687+pgleeson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/OpenSourceBrain/osb-model-validation/sessions/8a2ac322-49af-4c5b-aa14-4e690a7bc22c Co-authored-by: pgleeson <1556687+pgleeson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/OpenSourceBrain/osb-model-validation/sessions/8a2ac322-49af-4c5b-aa14-4e690a7bc22c Co-authored-by: pgleeson <1556687+pgleeson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/OpenSourceBrain/osb-model-validation/sessions/8a2ac322-49af-4c5b-aa14-4e690a7bc22c Co-authored-by: pgleeson <1556687+pgleeson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove python2 related code as no longer supported
Drop Python 2 compatibility branches across OMV runtime/install paths
May 18, 2026
pgleeson
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OMV still contained Python 2-era conditionals in core install and execution paths despite Python 2 no longer being supported. This PR removes those branches and normalizes behavior to Python 3-only code paths.
Engine install path cleanup
omv/engines/getnetpyne.py.omv/engines/getnrn.pyto Python 3 assumptions, with a single default constant (DEFAULT_NEURON_VERSION).7.8.x,8.x) via_supports_pip_install(...).Runtime execution path cleanup
omv/engines/neuron_.pyomv/engines/pyneuron.pyParser/output simplification
omv/parse_omt.pywhere both branches were identical.Legacy generated CI config alignment
2.7to3.12inomv/autogen.py.Focused regression coverage
omv/test/test_drop_py2_bits.pyto lock in:Example of the simplification: