Repository navigation
chore: use FastExpressionCompiler 6.0.0 from NuGet instead of the vendored DLL - #2505
Merged
Merged
Conversation
…dored DLL The vendored DLL was a master build carrying the fix for dadhi/FastExpressionCompiler#520 (unsigned modulo compiled as signed rem). FastExpressionCompiler 6.0.0 contains that fix.
maximilien-noal
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3rdparty/FastExpressionCompiler.dll(a build of upstream master5509b1f0, labelled 5.4.1) with theFastExpressionCompiler6.0.0 NuGet package.CompileFast()emitsrem(signed) instead ofrem.un(unsigned) forExpression.Modulowith block-localuintvariables dadhi/FastExpressionCompiler#520 (CompileFast()emitted signedremfor unsigned modulo). The official 5.4.1 package was published before that fix landed; v6.0.0 contains it (it is 64 commits ahead of5509b1f0and 0 behind).<None Include=... Pack="true">hack: the Spice86.Core nupkg now declares FastExpressionCompiler 6.0.0 as a dependency instead of embedding the DLL.3rdparty/.Test plan
dotnet build src/Spice86.sln: 0 warnings, 0 errorsdotnet test --project tests/Spice86.Tests -- --filter-not-class '*SingleStepTest*': 7871/7871 passedSPICE86_JIT_COMPILED_RUN=1 dotnet test --project tests/Spice86.Tests -- --filter-class '*AsmScenarioTest*': 455/455 passed, includingdiv2div2(wrong quotient/remainder bytes), so the test catches build(deps): bump Avalonia.Themes.Fluent from 11.0.5 to 11.0.6 in /src/Spice86 #520dotnet pack src/Spice86.Core: nuspec lists FastExpressionCompiler 6.0.0 as a dependency, no DLL underlib/