Skip to content

chore: use FastExpressionCompiler 6.0.0 from NuGet instead of the vendored DLL - #2505

Merged
kevinferrare merged 1 commit into
masterfrom
chore/fec-nuget
Nov 11, 2026
Merged

kevinferrare merged 1 commit into
masterfrom
chore/fec-nuget

Conversation

@kevinferrare

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • dotnet build src/Spice86.sln: 0 warnings, 0 errors
  • dotnet test --project tests/Spice86.Tests -- --filter-not-class '*SingleStepTest*': 7871/7871 passed
  • SPICE86_JIT_COMPILED_RUN=1 dotnet test --project tests/Spice86.Tests -- --filter-class '*AsmScenarioTest*': 455/455 passed, including div2
  • Negative control: with the official 5.4.1 package, the same compiled run fails exactly div2 (wrong quotient/remainder bytes), so the test catches build(deps): bump Avalonia.Themes.Fluent from 11.0.5 to 11.0.6 in /src/Spice86 #520
  • dotnet pack src/Spice86.Core: nuspec lists FastExpressionCompiler 6.0.0 as a dependency, no DLL under lib/
  • Performance benchmark against master

…dored DLL

The vendored DLL was a master build carrying the fix for dadhi/FastExpressionCompiler#520
(unsigned modulo compiled as signed rem). FastExpressionCompiler 6.0.0 contains that fix.
Copilot AI balanced review requested due to automatic review settings November 11, 2026 22:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@kevinferrare
kevinferrare merged commit e05e957 into master Nov 11, 2026
5 checks passed
@maximilien-noal
maximilien-noal deleted the chore/fec-nuget branch November 15, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants