Skip to content

editoast: remove Regulator::group_members #16739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
leovalais wants to merge 8 commits into
base: dev
Choose a base branch
from
Draft

editoast: remove Regulator::group_members #16739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
475ea67
editoast: authz: define `authz::v2::group` for organization
leovalais May 12, 2026
1001051
editoast: authz: define `authz::v2::roles` for organization
leovalais May 12, 2026
4a1c401
editoast: authz: define `authz::v2::infra` for organization
leovalais May 12, 2026
a205abd
editoast: authz: move `trait TestClientExt` in its own module
leovalais May 12, 2026
27df41d
editoast: cargo fmt
leovalais May 13, 2026
bfb72b5
merge
leovalais May 13, 2026
c91287e
editoast: authz: add `Protected::from_iter`
leovalais May 13, 2026
c11b377
editoast: remove `Regulator::group_members`
leovalais May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions editoast/authz/src/regulator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,25 +131,6 @@ impl<S: StorageDriver> Regulator<S> {
Ok(groups.users.into_iter().collect())
}

/// Returns the IDs of the users which are members of the provided group
#[tracing::instrument(skip_all, fields(group), ret(level = Level::DEBUG), err)]
pub async fn group_members(&self, group: &Group) -> Result<HashSet<User>, Error<S::Error>> {
if !self.group_exists(group.0).await? {
return Err(Error::UnknownSubject(group.0));
}
let members = self
.openfga
.list_users(Group::member().query_users(group))
.await
.map_err(QueryError::parsing_ok)?;

debug_assert!(
members.public_access.is_none(),
"we don't write public accesses for groups"
);
Ok(members.users.into_iter().collect())
}

#[tracing::instrument(skip(self), ret(level = Level::DEBUG), err)]
pub async fn user_roles(&self, user: &User) -> Result<HashSet<Role>, Error<S::Error>> {
// no need to check for user inexistence, an empty set will be returned in this case
Expand Down
Loading
Loading