front: handle RaiMI errors with forwarded status #16711
Open
Synar wants to merge 1 commit into
Open
Conversation
Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #14865
We handled most of RaiMI errors correctly, as they were of the form
"detail": string.However when RaiMI was forwarding a status it received to the front, it instead uses the format
"detail": {"error": string, "status_code": number}, which we did not handle well.Before this pr:
After this pr (please don't pay attention to the language of the header or the error box size, only to the error message):
