front: handle unrecognized track in itinerary modal

[theocrsb]

closes #16553

import this train to test it
unknowntrack.json

At the moment, the track names that have been added are not yet visible in the drop-down list. This will be resolved with the latest PR (once the back-end PR has been merged).

[Akctarus]

Can't you use black10 ?

Suggested change

	// blackAlpha10
	background-color: rgba(0, 0, 0, 0.1);
	background-color: var(--black10);

[theocrsb]

Black10 is different. where we using transparency

[SarahBellaha]

You can totally use var(--black10) 👍
rgba(0, 0, 0, 0.1) means you are using the black color with 10% opacity

[Akctarus]

tested, LGTM

[SarahBellaha]

Suggested change

	"noComputation": "there will be no computation for this train",
	"noComputation": "There will be no computation for this train.",

[SarahBellaha]

Suggested change

	"noComputation": "il n'y aura pas de calcul pour ce train",
	"noComputation": "Il n'y aura pas de calcul pour ce train.",

[SarahBellaha]

I find this naming/logic combination a bit odd: isTrackNameUnknown is computed through a negated condition, which makes the code less intuitive to read.
I think it would be clearer to go back to:

const isValidLocalTrackName = local_track_name
          ? matchedOp?.parts.some((part) => {
              const track = trackSectionsById[part.track];
              if (!track) return false;
              return local_track_name === part.local_track_name;
            })
          : false;

Also, if local_track_name is undefined, i believe isValidLocalTrackName should be false rather than true.
You can then use it l.139 with a negation :)

[SarahBellaha]

Suggested change

	? { ...item, location: { ...item.location, local_track_name: trackName || undefined } }
	? { ...item, location: { ...item.location, local_track_name: trackName } }

[SarahBellaha]

You can only pass the trainScheduleId here

[SarahBellaha]

Same for this, you can sort of re-use a part of the updatePacedTrain helper by spliting it like :

export async function updateTrainSchedule(dispatch: AppDispatch, id: number, trainSchedule: TrainSchedule) {
  await dispatch(
    osrdEditoastApi.endpoints.putTrainSchedulesById.initiate({
      id,
      trainSchedule,
    })
  ).unwrap();
}

async function updatePacedTrain(dispatch: AppDispatch, id: number, trainSchedule: TrainSchedule) {
  if (trainSchedule.paced?.exceptions && trainSchedule.paced.exceptions.length > 0) {
    console.error(
      'updatePacedTrain: exceptions should not be included in the paced field. Use exception endpoints instead.'
    );
  }
  await updateTrainSchedule(dispatch, id, trainSchedule);
}

[SarahBellaha]

You can totally use var(--black10) 👍
rgba(0, 0, 0, 0.1) means you are using the black color with 10% opacity

[SarahBellaha]

Suggested change

	<Banner type="info" message={`${t('alertInvalidOP')} ${t('noComputation')}`} />
	<Banner type="info" message={`${t('alertInvalidOP')}. ${t('noComputation')}`} />

You can either add the missing period between the two sentences here or, better, directly in the translation file :)

[SarahBellaha]

Suggested change

	<Banner type="info" message={`${pathfindingError} ${t('noComputation')}`} />
	<Banner type="info" message={`${pathfindingError}. ${t('noComputation')}`} />

Same