Move getMaxMessageId off EDT in MessageBrowser.runSearch#317
Open
NicoPiel wants to merge 1 commit into
Open
Conversation
getMaxMessageId is a blocking HTTP call that was executed on the Swing EDT, freezing the UI while waiting for the server response. Moved it into SwingWorker.doInBackground(); all subsequent UI updates run in done() back on the EDT. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
NicoPiel
requested review from
a team,
gibson9583,
jonbartels,
kayyagari,
mgaffigan,
pacmano1,
ssrowe and
tonygermano
and removed request for
a team
mgaffigan
requested changes
May 27, 2026
Contributor
mgaffigan
left a comment
mgaffigan
left a comment
There was a problem hiding this comment.
Need protection against reentrance, otherwise double-click will race with indeterminate state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getMaxMessageId is a blocking HTTP call that was executed on the Swing
EDT, freezing the UI while waiting for the server response. Moved it
into SwingWorker.doInBackground(); all subsequent UI updates run in
done() back on the EDT.