Close URL stream via try-with-resources in ExtensionUtil#312
Closed
NicoPiel wants to merge 9 commits into
Closed
Conversation
$gc()/$g() JS APIs call lock() on keys never registered via putSync(), causing NPE; throw IllegalArgumentException with clear message instead Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
replaceValues() can return null; calling toString() unconditionally throws NPE and halts channel message processing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
& and \ in env var values corrupt mirth.properties silently; add escape_sed_replacement() helper and apply to all sed replacement interpolations Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
currentState is read across threads in isActive() and state checks without synchronization; missing volatile allows stale cached reads, letting channels continue processing after stop Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
commit() snapshots live stats map then inverts non-atomically; concurrent update() calls between snapshot and inversion are silently lost; synchronize snapshot+inversion on the statistics object Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Integer.MAX_VALUE maximumPoolSize creates unlimited threads under JS load; cap at 100 to prevent OOM and OS thread exhaustion Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
export() ran network I/O and disk writes synchronously on EDT, freezing entire Mirth client UI; move work to SwingWorker.doInBackground() Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
CI built with Java 17 while Docker runtime uses Java 21; behavior differences between versions are invisible in CI; align to Java 21. Also drop java-package: 'jdk+fx' — no JavaFX dependencies exist in the build files, and the zulu jdk+fx variant is not available for 21. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
in.close() not in finally; exception during readLine() leaks the underlying HTTP connection; use try-with-resources to guarantee closure on all paths Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Test Results 4 files - 107 6 suites - 208 9s ⏱️ - 5m 41s Results for commit 78946bf. ± Comparison against base commit 5423492. This pull request removes 636 tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in.close() not in finally; exception during readLine() leaks the underlying HTTP connection; use try-with-resources to guarantee closure on all paths