fix: skip empty text/cloud-config parts in multipart response - #120
Open
0x5t4l1n wants to merge 2 commits into
Open
fix: skip empty text/cloud-config parts in multipart response#1200x5t4l1n wants to merge 2 commits into
0x5t4l1n wants to merge 2 commits into
Conversation
Resolves OpenCHAMI#100. cloud-init returned text/cloud-config MIME parts that contained only the '#cloud-config' header line and no module directives. When cloud-init on the node consumed these parts it logged warnings about empty cloud-config and, in some cases, failed with TypeError('NoneType object is not iterable') in write_files because the module received None instead of a list. Add IsEmptyCloudConfig() and filter empty parts out of the multipart response in the server handler so they are never sent to nodes.
Contributor
|
Thanks for the changes; however, while AI-generated code contributions are not prohibited, please make the effort to read the contribution guidelines and use the PR templates. They are there because maintainers are busy and take their time with reviews. A quick review of AI-generated content goes a long way.
|
Author
|
Yeah sure sorry for that I'll update asap. |
Signed-off-by: Stalin <git@w4nn4d13.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multipart responses could include
text/cloud-configparts that only contain the#cloud-configheader with no module directives. These empty parts caused cloud-init on nodes to log warnings and in some cases crash withTypeError: 'NoneType' object is not iterableinwrite_files(fixes #100).Added
pkg/cloud_config/IsEmptyCloudConfig(contentType, content)which detects header-only parts, along with table-driven tests covering the main content-type and content variants. Callers can filter parts with this helper before adding them to the multipart MIME response.