Cherry-pick 3.5 performCleanup in release.JenkinsFile to clean the .npmrc file from the correct folder#3047
Open
IvkoniB wants to merge 1 commit into
Conversation
…he correct folder (#3043) ## What Updated `performCleanup` step in `release.JenkinsFile` to remove the `.npmrc` file from the correct directory. The cleanup path was corrected from `cypress-test` to `e2e-tests`. ## Why `.npmrc` credentials file was not being removed as part of the final release step because it was pointing to the wrong folder. This left sensitive credentials behind after pipeline execution and made the cleanup step ineffective. ## How Adjusted cleanup logic in `release.JenkinsFile` so that `performCleanup` targets the `e2e-tests` directory instead of `cypress-test`, ensuring the `.npmrc` file is properly removed during the final stage of the pipeline. ## Testing Have not tested due to unnecessary potential version collision with artifacts and metadata ## Screenshots N/A ## Checklist - [x] Branch name - [x] Target branch - [x] Commit messages - [x] Squash commits - [x] MR name - [x] MR Description - [ ] Tests - [ ] Browser support verified (cherry picked from commit bcf56cf)
|
IvkoniB
changed the title
IvkoniB
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updated
performCleanupstep inrelease.JenkinsFileto remove the.npmrcfile from the correct directory. The cleanup path was corrected fromcypress-testtoe2e-tests.Why
.npmrccredentials file was not being removed as part of the final release step because it was pointing to the wrong folder. This left sensitive credentials behind after pipeline execution and made the cleanup step ineffective.How
Adjusted cleanup logic in
release.JenkinsFileso thatperformCleanuptargets thee2e-testsdirectory instead ofcypress-test, ensuring the.npmrcfile is properly removed during the final stage of the pipeline.Testing
Have not tested due to unnecessary potential version collision with artifacts and metadata
Screenshots
N/A
Checklist
(cherry picked from commit bcf56cf)