feat: allow passing an Auth to ExtensionBootstrap.init - #7
Merged
Conversation
Minestom binds the Auth to the ServerProcess in MinecraftServer.init(Auth) and offers no way to swap it afterwards. ExtensionBootstrap.init() called the no-arg MinecraftServer.init(), which hardcodes Auth.Offline - so a server started through this bootstrap could never enable Velocity modern forwarding at all. The new init(Auth) overload hands the caller's Auth straight to MinecraftServer.init(Auth); init() keeps its previous offline behaviour by delegating to it with Auth.Offline.
Test results 21 files 21 suites 1m 57s ⏱️ Results for commit 47414a2. |
This was referenced Aug 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Minestom binds the
Authto theServerProcessinsideMinecraftServer.init(Auth)and offers no way to swap it afterwards.ExtensionBootstrap.init()called the no-argMinecraftServer.init(), which hardcodesAuth.Offline.Consequence: a server started through this bootstrap could never enable Velocity modern forwarding — not before
init()(the value is overwritten), not after (the process keeps theAuthit was built with).Change
ExtensionBootstrap.init(Auth)overload that hands the caller'sAuthstraight toMinecraftServer.init(Auth).init()keeps its previous behaviour by delegating withAuth.Offline— no call site has to change.ExtensionBootstrapAuthTestpins both directions, since nothing else links the bootstrap to the auth the process ends up with.Verification
./gradlew buildgreen across all modules.