fix: drop mycelium-bom in favour of direct Minestom coordinates - #5
Merged
Conversation
mycelium-bom supplied the Minestom and JUnit versions, but it is not resolvable without OneLiteFeather credentials: 404 on the public repository path and on Maven Central, 401 behind auth. Gradle records it as a real runtime dependency (platform category) rather than a constraint, so every consumer outside the organisation failed to resolve this library. Versions are now declared in the catalog directly: - net.minestom:minestom 2026.07.22-26.2 - JUnit 6.1.2 With the platform gone, nothing resolves from repo.onelitefeather.dev any more, so that repository is removed from dependencyResolutionManagement - building this project no longer needs credentials at all. Publishing is unaffected and still targets the same repository. Verified: 54 tests pass, and the published POM and module metadata of minestom-extensions carry no dependencyManagement block and only publicly resolvable runtime dependencies.
Test results 18 files 18 suites 1m 41s ⏱️ Results for commit b88f15b. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
mycelium-bomplatform and declares the Minestom and JUnit versions in the version catalog instead.Why
mycelium-bomsupplied the Minestom and JUnit versions, but it is not resolvable outside the organisation:repo.onelitefeather.dev/releases/…/mycelium-bom-1.7.1.pomrepo.onelitefeather.dev/onelitefeather-releases/…Gradle records it in
runtimeElementsas a real dependency of theplatformcategory, not as a constraint — so it is not just a build-time concern. Every consumer outside OneLiteFeather failed to resolvenet.onelitefeather:minestom-extensions.What changed
net.minestom:minestomat2026.07.22-26.2, JUnit at6.1.2(what the platform resolved to).platform(libs.myclium.bom)removed from all four modules that declared it.repo.onelitefeather.devany more, so that repository is removed fromdependencyResolutionManagement. Building this project no longer requires credentials. Publishing is untouched and still targets the same repository.Verification
./gradlew build— 54 tests passpublishToMavenLocal— the POM and Gradle module metadata ofminestom-extensionscarry nodependencyManagementblock; runtime dependencies aremaven-resolver-*andslf4j-api, all publicly resolvabledependencyManagementblock inminestom-extensions-bomis its own constraint list and unaffectedNote on the commit type
Typed
fix:rather thanbuild:on purpose —build:would not produce a Release Please entry, and this needs to ship for downstream consumers to resolve the library at all.Context
This unblocks embedding LuckPerms as a Minestom extension: the LuckPerms fork cannot depend on
minestom-extensionswhile its transitive platform is credential-gated.