feat(vulpes): allow patch in the backend cors configuration - #230
Merged
Conversation
The stelaris-ui CORS configuration pinned the allowed origin but left allowed-methods unset, relying on Micronaut's implicit any-method default. Spell the method set out so PATCH — used by Stelaris for partial updates — is explicitly covered rather than incidental. Applied to both the prod and dev overlay. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V9romuepQH44Gcuae5pH5v
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
stelaris-uiCORS configuration on the Vulpes backend pinnedallowed-originsbut leftallowed-methodsunset. Micronaut treats a missingallowed-methodsas "any method", so this spells the set out —GET, POST, PUT, PATCH, DELETE, OPTIONS— making PATCH explicitly covered instead of incidental.Applied to both overlays:
apps/clusters/feathre-core/apps/vulpes-backend/release.yamlapps/clusters/feathre-core/apps/vulpes-backend-dev/release.yamlNotes
micronautchart carries achecksum/configannotation on the Deployment, so the pods roll on the Helm upgrade — no manualrollout restart.allowed-headers(a custom header orContent-Type: application/merge-patch+json), or a missing@Patchroute answering 405 before CORS applies.Validation
./scripts/validate.sh— 0 invalid, 0 errors.🤖 Generated with Claude Code
https://claude.ai/code/session_01V9romuepQH44Gcuae5pH5v