Codex/device attestation voucher proof - #851
Open
ByteZhang1024 wants to merge 12 commits into
Open
Conversation
originalix
reviewed
Jul 30, 2026
| } catch { | ||
| throw new Error('Ledger genuine-check relay URL is invalid'); | ||
| } | ||
| if (parsed.protocol !== 'wss:') { |
Contributor
There was a problem hiding this comment.
P1: [限制 Ledger relay 到受信任的 OneKey endpoint]
当 challenge 响应或桥接调用把 ledgerGenuineCheckWebSocketUrl 设置为任意 wss:// URL 时，这里只验证 protocol，随后就把该值交给 DMK。这样恶意或误配置的 origin、userinfo、query、fragment、内部地址或非预期 path 都能承接 genuine-check 网络流量和设备证明数据，绕过仓库的网络白名单。
请让 connector 从构造期静态环境配置取得允许的 OneKey origin，并在这里精确校验 hostname/origin、固定 /v1/ledger/session/<single-use-token> path，同时拒绝 userinfo、query 和 fragment；校验失败时不要重建 DMK。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.