feat(web): dynamic metadata and JSON-LD structured data for vault detail pages (#229) - #346
Merged
Dev-Zully merged 1 commit intoAug 26, 2026
Conversation
|
@osaigbovotestimony7-sys Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements dynamic Open Graph and Twitter Card metadata generation (
generateMetadata()) and Schema.org structured data (JSON-LD) for vault detail pages (/vault/[id]), while extending theSEOcomponent to support dynamic tags and structured data.Related Issue
Closes #229
Changes
Web SEO & Dynamic Metadata
web/components/SEO.tsxjsonLd,customOg,ogType, andtwitterCardprops toSeoProps.<script type="application/ld+json">for structured data and dynamic Open Graph tags.web/lib/vault-metadata.tsbuildVaultMetadata: Generates dynamic Next.jsMetadatawith Open Graph tags containing vault name, balance, and APY.buildVaultJsonLd: Generates Schema.orgFinancialProductstructured data.buildVaultOgTags: Generates custom OG dictionary for vault metrics.fetchVaultData: Fetches or resolves vault data with fallback support.web/app/vault/[id]/page.tsxgenerateMetadata()for App Router dynamic vault detail route.web/app/vaults/[id]/page.tsxweb/pages/vault/[id].tsxSEOcomponent with JSON-LD and custom OG tags.web/__tests__/vault-metadata.test.cjsVerification Results
generateMetadata()for dynamic vault pagesweb/app/vault/[id]/page.tsxwith dynamic params resolutionopenGraph.title,openGraph.description,twitter, and customvault:*OG tagsFinancialProductJSON-LD rendered in script tags